Skip to content

Conversation

@binuj
Copy link
Contributor

@binuj binuj commented Nov 1, 2018

Description

Generated SDK files for Microsoft.DataMigration for version 0.6.0-preview. This is result of swagger updated with changes Schema migration, project files resource and MongoDb scenario.

Link to the swagger changes pull request
Azure/azure-rest-api-specs#4240


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@haitsongmsft
Copy link

:)

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please regenerate the code using this script
Also commit all files modified (including .txt files)

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from the comment below

@dsgouda
Copy link
Contributor

dsgouda commented Nov 12, 2018

@azuresdkci retest this please

…. Added tests for files resource. Generated files using 'DataMigration\Management.DataMigration\generate.ps1'. Updated Description and PackageReleaseNotes notes.
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda dsgouda merged commit 7827ff8 into Azure:psSdkJson6 Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants