Skip to content

Updates to Schema migration, project files resource and MongoDb scenario. #4240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marstr merged 1 commit into from
Oct 24, 2018
Merged

Updates to Schema migration, project files resource and MongoDb scenario. #4240

marstr merged 1 commit into from
Oct 24, 2018

Conversation

@binuj
Copy link
Contributor

@binuj binuj commented Oct 16, 2018

Add missing files resource management options for Schema migration scenario.
Add support for MongoDb migration scenario.

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI AutorestCI mentioned this pull request Oct 16, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Oct 16, 2018 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3475

@AutorestCI
Copy link

AutorestCI commented Oct 16, 2018 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3128

@azuresdkci azuresdkci requested a review from jianghaolu October 16, 2018 05:07
@AutorestCI AutorestCI mentioned this pull request Oct 16, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Oct 16, 2018 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3948

@AutorestCI AutorestCI mentioned this pull request Oct 16, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Oct 16, 2018 •
edited
Loading

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#308

@azuresdkci
Copy link
Contributor

azuresdkci commented Oct 16, 2018

Can one of the admins verify this patch?

admilazz
admilazz approved these changes Oct 16, 2018
View reviewed changes
Copy link

@admilazz admilazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any problems introduced by this merge.

@jianghaolu jianghaolu removed their assignment Oct 17, 2018
@jianghaolu
Copy link
Contributor

jianghaolu commented Oct 17, 2018

1 day away from releasing v2 fluent SDK - reassign.

@jianghaolu jianghaolu removed their request for review October 17, 2018 19:02
@azuresdkci azuresdkci requested a review from marstr October 17, 2018 19:04
marstr
marstr requested changes Oct 19, 2018
View reviewed changes
Copy link
Member

@marstr marstr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One example needs updating:
https://travis-ci.org/Azure/azure-rest-api-specs/jobs/442001287#L615

Other than that, I don't see anything conspicuous about this PR.

@marstr marstr removed the Reassign label Oct 19, 2018
@binuj
Add missing files resource management options for Schema migration sc…
f731816 
…enario. Add support for MongoDb migration scenario. Iter2: Fixed Files_Delete example to include fileName parameter
@AutorestCI AutorestCI mentioned this pull request Oct 22, 2018
Merged
@marstr
Copy link
Member

marstr commented Oct 23, 2018

Ready for me to merge, @binuj?

@binuj
Copy link
Contributor Author

binuj commented Oct 23, 2018

Yes, please merge.

haitsongmsft
haitsongmsft approved these changes Oct 23, 2018
View reviewed changes
Copy link
Contributor

@haitsongmsft haitsongmsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please merge the PR

@marstr marstr merged commit 5ed70a2 into Azure:master Oct 24, 2018
@AutorestCI
Copy link

AutorestCI commented Oct 24, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@binuj binuj mentioned this pull request Nov 2, 2018
Merged
9 tasks
mccleanp pushed a commit that referenced this pull request Mar 23, 2022
@martincyruswolfenbarger
Support flink cluster profile. (#4240)
c767776 
* Support flink cluster profile.

* Add flink to known words list.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marstr marstr marstr approved these changes

@hitenjava hitenjava Awaiting requested review from hitenjava hitenjava is a code owner

@huang91shu huang91shu Awaiting requested review from huang91shu

+2 more reviewers

@haitsongmsft haitsongmsft haitsongmsft approved these changes

@admilazz admilazz admilazz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@marstr marstr

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@binuj @AutorestCI @azuresdkci @jianghaolu @marstr @haitsongmsft @admilazz