ShortTermRetentionManagadInstance#4982
Conversation
|
Squashed commits from #4934 |
dsgouda
left a comment
There was a problem hiding this comment.
There should be a .txt file generated/modified when code is generated, please commit this file too
75018cd to
a50c4ab
Compare
|
I regenerated files and pushed them. I used synced azure-rest-api branch before regenerating, and it generated some files that are not connected to my changes. Is that a problem? |
|
These files are expected |
|
@v-djnisi I have approved the PR but this cannot be merged until the PR for REST spec is merged. |
src/SDKs/SqlManagement/Sql.Tests/ManagedDatabaseRestoreScenarioTests.cs
Outdated
Show resolved
Hide resolved
jaredmoo
left a comment
There was a problem hiding this comment.
Change looks good overall, just need to update csproj & AssemblyInfo
src/SDKs/SqlManagement/Management.Sql/Microsoft.Azure.Management.Sql.csproj
Outdated
Show resolved
Hide resolved
src/SDKs/SqlManagement/Sql.Tests/ManagedDatabaseRestoreScenarioTests.cs
Outdated
Show resolved
Hide resolved
da44945 to
03e7b32
Compare
03e7b32 to
91af88d
Compare
9411339 to
301ee95
Compare
|
@dsgouda please take a look at Travis build failure, it's not in our area |
|
@jaredmoo @dsgouda I don't see any failures. One more thing, is there a reason why we are not merging this API? It seems to me that this PR is waiting on rest-api-for-specs, and rest-api-for-specs is waiting on this PR. Is there anything I can do besides pinging? We need to finish powershell by the end of the month. |
|
@dsgouda azure-rest-api-specs just got approved and merged. |

Description
Azure-Rest-API-Specs pull request: Azure/azure-rest-api-specs#3979
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.