ShortTermRetentionManagedInstance#4934
Closed
v-djnisi wants to merge 4 commits intoAzure:psSdkJson6from
Closed
Conversation
Contributor
|
Can one of the admins verify this patch? |
10 tasks
Contributor
|
@v-djnisi please join aka.ms/azuregithub to get access to the azure org and get authenticated to kick off CI process. |
Contributor
Author
|
@shahabhijeet Done |
dsgouda
suggested changes
Oct 29, 2018
Contributor
dsgouda
left a comment
There was a problem hiding this comment.
Looks good for the most part
src/SDKs/SqlManagement/Management.Sql/Microsoft.Azure.Management.Sql.csproj
Show resolved
Hide resolved
src/SDKs/SqlManagement/Management.Sql/Generated/SdkInfo_SqlManagementClient.cs
Show resolved
Hide resolved
Contributor
dsgouda
suggested changes
Oct 30, 2018
Contributor
dsgouda
left a comment
There was a problem hiding this comment.
Looks good, please squash commits into a single commit and we should be good to merge
Contributor
Author
|
@dsgouda This is the first time I am using git. I synced the code midway, and I have no idea how to to squash commits, since they are not consecutive, and are already pushed. I tried rebasing, but couldn't get it to work properly. Can you help me with this? |
Contributor
|
There is a simple way to do it.
Hope this helps |
9 tasks
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This are clients for short term retention on managed instance. I generated new clients and added new scenario tests.
Azure-Rest-API-Specs pull request: Azure/azure-rest-api-specs#3979
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.