Skip to content

Container Instance: Updating for October Release#4851

Merged
dsgouda merged 5 commits intoAzure:psSdkJson6from
samkreter:sakreter-UpdatingToOctoberRelease
Oct 11, 2018
Merged

Container Instance: Updating for October Release#4851
dsgouda merged 5 commits intoAzure:psSdkJson6from
samkreter:sakreter-UpdatingToOctoberRelease

Conversation

@samkreter
Copy link
Copy Markdown

@samkreter samkreter commented Oct 9, 2018

Description

This PR is regenerating the sdk based of the latest swagger spec with changes from this PR: Azure/azure-rest-api-specs#4058


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

Copy link
Copy Markdown
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samkreter could you pull latest changes from psSdkJson6 and run msbuild build.proj before running the generate.ps1 script

Copy link
Copy Markdown
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda dsgouda merged commit 88f84ef into Azure:psSdkJson6 Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants