Container Instance October Swagger by samkreter · Pull Request #4058 · Azure/azure-rest-api-specs

samkreter · 2018-10-02T17:01:35Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

AutorestCI · 2018-10-02T17:02:06Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3489

azuresdkci · 2018-10-02T17:02:26Z

Can one of the admins verify this patch?

AutorestCI · 2018-10-02T17:03:12Z

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

AutorestCI · 2018-10-02T17:04:45Z

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3753

AutorestCI · 2018-10-02T17:05:31Z

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1621

AutorestCI · 2018-10-02T17:06:34Z

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2292

AutorestCI · 2018-10-02T17:08:20Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2894

jhendrixMSFT · 2018-10-02T17:09:09Z

...stance/resource-manager/Microsoft.ContainerInstance/stable/2018-10-01/containerInstance.json

+          "required": [
+            "properties"
+          ],
+          "identity": {


This is in the wrong place and is the cause for the autorest codegen to fail. Presumably this is supposed to go under properties?

jhendrixMSFT · 2018-10-02T18:52:27Z

...er/Microsoft.ContainerInstance/stable/2018-10-01/examples/ContainerGroupsCreateOrUpdate.json

      "id": "/subscriptions/subid/resourceGroups/demo/providers/Microsoft.ContainerInstance/containerGroups/demo1",
      "location": "west us",
      "name": "demo1",
+      "Identity": { 


This example also needs to be updated after your last commit, see the failure in the model validator log.

jhendrixMSFT · 2018-10-02T19:08:47Z

Issue Azure/azure-openapi-validator#176 to track what I believe is a false positive linter error.

jhendrixMSFT · 2018-10-02T19:27:09Z

...er/Microsoft.ContainerInstance/stable/2018-10-01/examples/ContainerGroupsCreateOrUpdate.json

Casing for this one is also wrong, see log. You can run the validation locally, see instructions here.

sakreter added 2 commits October 1, 2018 15:48

Adding 2018-10-01 Swagger

54ed116

adding MSI swagger endpoints

d08180f

azuresdkci assigned jhendrixMSFT Oct 2, 2018

azuresdkci requested a review from jhendrixMSFT October 2, 2018 17:02

jhendrixMSFT requested changes Oct 2, 2018

View reviewed changes

Moving MSI Identity object to correct properties

9a55414

jhendrixMSFT reviewed Oct 2, 2018

View reviewed changes

jhendrixMSFT mentioned this pull request Oct 2, 2018

Some paths incorrectly trigger R2059 Unique Resource Paths Azure/oav#328

Closed

jhendrixMSFT reviewed Oct 2, 2018

View reviewed changes

jhendrixMSFT mentioned this pull request Oct 2, 2018

False positives for specs appearing like they have two RPs in them Azure/azure-openapi-validator#176

Closed

changing identity casing for it to work

060f19a

samkreter force-pushed the sakreter-AddingOctoberSwagger branch from 17d26ec to 060f19a Compare October 2, 2018 20:43

jhendrixMSFT approved these changes Oct 2, 2018

View reviewed changes

suppress UniqueResourcePaths due to false positive

06fe7d9

jhendrixMSFT merged commit da7505b into Azure:master Oct 2, 2018

samkreter mentioned this pull request Oct 9, 2018

Container Instance: Updating for October Release Azure/azure-sdk-for-net#4851

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Container Instance October Swagger#4058

Container Instance October Swagger#4058
jhendrixMSFT merged 5 commits intoAzure:masterfrom
samkreter:sakreter-AddingOctoberSwagger

samkreter commented Oct 2, 2018

Uh oh!

AutorestCI commented Oct 2, 2018 •

edited

Loading

Uh oh!

azuresdkci commented Oct 2, 2018

Uh oh!

AutorestCI commented Oct 2, 2018 •

edited

Loading

Uh oh!

AutorestCI commented Oct 2, 2018 •

edited

Loading

Uh oh!

AutorestCI commented Oct 2, 2018 •

edited

Loading

Uh oh!

AutorestCI commented Oct 2, 2018 •

edited

Loading

Uh oh!

AutorestCI commented Oct 2, 2018 •

edited

Loading

Uh oh!

jhendrixMSFT Oct 2, 2018

Uh oh!

jhendrixMSFT Oct 2, 2018

Uh oh!

jhendrixMSFT commented Oct 2, 2018 •

edited

Loading

Uh oh!

jhendrixMSFT Oct 2, 2018 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

samkreter commented Oct 2, 2018

PR information

Quality of Swagger

Uh oh!

AutorestCI commented Oct 2, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

azuresdkci commented Oct 2, 2018

Uh oh!

AutorestCI commented Oct 2, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-js

Uh oh!

AutorestCI commented Oct 2, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-node

Uh oh!

AutorestCI commented Oct 2, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

AutorestCI commented Oct 2, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

AutorestCI commented Oct 2, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

jhendrixMSFT Oct 2, 2018

Choose a reason for hiding this comment

Uh oh!

jhendrixMSFT Oct 2, 2018

Choose a reason for hiding this comment

Uh oh!

jhendrixMSFT commented Oct 2, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jhendrixMSFT Oct 2, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

AutorestCI commented Oct 2, 2018 •

edited

Loading

AutorestCI commented Oct 2, 2018 •

edited

Loading

AutorestCI commented Oct 2, 2018 •

edited

Loading

AutorestCI commented Oct 2, 2018 •

edited

Loading

AutorestCI commented Oct 2, 2018 •

edited

Loading

AutorestCI commented Oct 2, 2018 •

edited

Loading

jhendrixMSFT commented Oct 2, 2018 •

edited

Loading

jhendrixMSFT Oct 2, 2018 •

edited

Loading