Skip to content

StorageSync Add ApiVersion 2018-07-01#4832

Closed
ankushbindlish2 wants to merge 2 commits intoAzure:psSdkJson6from
ankushbindlish2:storagesync-Add_ApiVersion-2018-07-01
Closed

StorageSync Add ApiVersion 2018-07-01#4832
ankushbindlish2 wants to merge 2 commits intoAzure:psSdkJson6from
ankushbindlish2:storagesync-Add_ApiVersion-2018-07-01

Conversation

@ankushbindlish2
Copy link
Member

@ankushbindlish2 ankushbindlish2 commented Oct 4, 2018

Spec : https://github.com/Azure/azure-rest-api-specs/blob/master/specification/storagesync/resource-manager/Microsoft.StorageSync/stable/2018-07-01/storagesync.json

PR : Azure/azure-rest-api-specs#4048

Description


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@dsgouda
Copy link
Contributor

dsgouda commented Oct 4, 2018

@ankushbindlish2 please post a link to the PR that introduced changes to existing spec

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The REST spec API version is bumped here. Please bump the major version number for nuget package in csproj and assemblyinfo.cs files
Also please update the PackageReleaseNotes in csproj

@ankushbindlish2
Copy link
Member Author

Will create a new PR when unit test is ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants