StorageSync Add ApiVersion 2018-07-01#4832
Closed
ankushbindlish2 wants to merge 2 commits intoAzure:psSdkJson6from
ankushbindlish2:storagesync-Add_ApiVersion-2018-07-01
Closed
StorageSync Add ApiVersion 2018-07-01#4832ankushbindlish2 wants to merge 2 commits intoAzure:psSdkJson6from ankushbindlish2:storagesync-Add_ApiVersion-2018-07-01
ankushbindlish2 wants to merge 2 commits intoAzure:psSdkJson6from
ankushbindlish2:storagesync-Add_ApiVersion-2018-07-01
Conversation
Contributor
|
@ankushbindlish2 please post a link to the PR that introduced changes to existing spec |
dsgouda
suggested changes
Oct 4, 2018
Contributor
dsgouda
left a comment
There was a problem hiding this comment.
The REST spec API version is bumped here. Please bump the major version number for nuget package in csproj and assemblyinfo.cs files
Also please update the PackageReleaseNotes in csproj
Member
Author
|
Will create a new PR when unit test is ready |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec : https://github.com/Azure/azure-rest-api-specs/blob/master/specification/storagesync/resource-manager/Microsoft.StorageSync/stable/2018-07-01/storagesync.json
PR : Azure/azure-rest-api-specs#4048
Description
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.