Skip to content

Swagger Update for Microsoft.StorageSync (2018-07-01) #4048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sergey-shandar merged 14 commits into from
Oct 4, 2018
Merged

Swagger Update for Microsoft.StorageSync (2018-07-01) #4048

sergey-shandar merged 14 commits into from
Oct 4, 2018

Conversation

@ankushbindlish2
Copy link
Member

@ankushbindlish2 ankushbindlish2 commented Oct 1, 2018 •
edited
Loading

  • Added TierFilesOlderThanDays in ServerEndpoint
  • Add TriggerRollover request
  • Remove Tags from ServerEndpoint

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@ankushbindlish2
Changes with schema change and request
026649d 
Changes with schema change and request
@azuresdkci
Copy link
Contributor

azuresdkci commented Oct 1, 2018

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Oct 1, 2018 •
edited
Loading

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

@AutorestCI
Copy link

AutorestCI commented Oct 1, 2018 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2734

@AutorestCI
Copy link

AutorestCI commented Oct 1, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Oct 1, 2018 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3761

@AutorestCI
Copy link

AutorestCI commented Oct 1, 2018 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2402

@AutorestCI AutorestCI mentioned this pull request Oct 1, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Oct 1, 2018 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2905

This was referenced Oct 1, 2018
Merged
Merged
Merged
@ankushbindlish2
Ran Validate examples
72f3d90 
cd h:\csharpsdk\azure-rest-api-specs\specification
npx autorest --validation --azure-validator --message-format=json  h:\csharpsdk\azure-rest-api-specs\specification\storagesync\resource-manager\readme.md
oav validate-spec h:\csharpsdk\azure-rest-api-specs\specification\storagesync\resource-manager\Microsoft.StorageSync\stable\2018-07-01\storagesync.json
oav validate-example h:\csharpsdk\azure-rest-api-specs\specification\storagesync\resource-manager\Microsoft.StorageSync\stable\2018-07-01\storagesync.json -f h:\csharpsdk\azure-rest-api-specs\output\Expected_1.log
@sergey-shandar sergey-shandar added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 1, 2018
sergey-shandar
sergey-shandar suggested changes Oct 2, 2018
View reviewed changes
sergey-shandar
sergey-shandar approved these changes Oct 3, 2018
View reviewed changes
Copy link
Contributor

@sergey-shandar sergey-shandar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need ARM approval.

@ravbhatnagar
Copy link
Contributor

ravbhatnagar commented Oct 3, 2018

Looks good. signing off from ARM side,

@ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMReviewInProgress WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 3, 2018
@sergey-shandar sergey-shandar merged commit 0dcce18 into Azure:master Oct 4, 2018
@ankushbindlish2 ankushbindlish2 mentioned this pull request Oct 4, 2018
Closed
9 tasks
@ankushbindlish2 ankushbindlish2 mentioned this pull request Oct 15, 2018
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@ravbhatnagar ravbhatnagar ravbhatnagar left review comments

@sergey-shandar sergey-shandar sergey-shandar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sergey-shandar sergey-shandar

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ankushbindlish2 @azuresdkci @AutorestCI @ravbhatnagar @sergey-shandar