Skip to content

Comments

[BingVisualSearch] Additional query parameters: mkt, safesearch, setlang#4772

Merged
dsgouda merged 2 commits intoAzure:psSdkJson6from
shakao:psSdkJson6
Sep 21, 2018
Merged

[BingVisualSearch] Additional query parameters: mkt, safesearch, setlang#4772
dsgouda merged 2 commits intoAzure:psSdkJson6from
shakao:psSdkJson6

Conversation

@shakao
Copy link
Contributor

@shakao shakao commented Sep 18, 2018

Description

Additional query parameters for the Visual Search API allowing users to specify market, safesearch level, and language for the results. REST spec PR link.


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@dsgouda
Copy link
Contributor

dsgouda commented Sep 19, 2018

Please link the related REST spec PR

<PackageId>Microsoft.Azure.CognitiveServices.Search.VisualSearch</PackageId>
<Description>This client library provides access to the Microsoft Cognitive Services Image Visual Search API.</Description>
<VersionPrefix>0.18.0-preview</VersionPrefix>
<VersionPrefix>1.0.0</VersionPrefix>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace VersionPrefix with Version

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated!

@shakao
Copy link
Contributor Author

shakao commented Sep 19, 2018

@dsgouda oh! sorry, i had it linked in the checklist but forgot to add it to the description. it's there now :)

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda dsgouda merged commit 8d598bb into Azure:psSdkJson6 Sep 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants