Skip to content

[Visual Search] Additional documentation, add discriminator types, up…#3637

Merged
hovsepm merged 1 commit intoAzure:masterfrom
shakao:master
Aug 16, 2018
Merged

[Visual Search] Additional documentation, add discriminator types, up…#3637
hovsepm merged 1 commit intoAzure:masterfrom
shakao:master

Conversation

@shakao
Copy link
Contributor

@shakao shakao commented Aug 14, 2018

…date example to remove outdated actions

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@shakao shakao requested a review from yangyuan as a code owner August 14, 2018 17:29
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Aug 14, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3160

@AutorestCI
Copy link

AutorestCI commented Aug 14, 2018

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@AutorestCI
Copy link

AutorestCI commented Aug 14, 2018

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Aug 14, 2018

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

@AutorestCI
Copy link

AutorestCI commented Aug 14, 2018

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

Copy link
Member

@yangyuan yangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hovsepm
Copy link
Contributor

hovsepm commented Aug 14, 2018

@shakao please fix the sample:

Validating "examples" and "x-ms-examples" in  specification/cognitiveservices/data-plane/VisualSearch/preview/v1.0/VisualSearch.json:
 error: 
operationId: Images_VisualSearch
scenario: Successful visual search
source: request
responseCode: ALL
severity: 0
errorCode: ONE_OF_MISSING
errorDetails:
  code: ONE_OF_MISSING
  params: []
  message: Data does not match any schemas from 'oneOf'
  path: paths//images/visualsearch/post/parameters/12
  description: >-
    The form data is an image binary. The Content-Disposition header's name
    parameter must be set to "image". You must specify an image binary if you do
    not use knowledgeRequest form data to specify the image; you may not use
    both forms to specify an image. You may specify knowledgeRequest form data
    and image form data in the same request only if knowledgeRequest form data
    specifies the cropArea field only  (it must not include an insights token or
    URL).
  inner:
    - code: INVALID_TYPE
      params:
        - file
        - string
      message: Expected type file but found type string
      path: paths//images/visualsearch/post/parameters/12

@shakao
Copy link
Contributor Author

shakao commented Aug 14, 2018

@hovsepm From previous PRs, I think this is a known issue with specifying "file" as the input type in the sample. Not sure if there's been a fix since, but I'm happy to update if you could point me to documentation on how to specify file inputs in the sample!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments