Csharp SDK for Microsoft.StorageSync Resource Provider for ApiVersion package-2018-04-02 by ankushbindlish2 · Pull Request #4729 · Azure/azure-sdk-for-net

ankushbindlish2 · 2018-08-31T19:54:37Z

Csharp SDK for Microsoft.StorageSync Resource Provider
https://github.com/Azure/azure-rest-api-specs/blob/master/specification/storagesync/resource-manager/readme.md

Description

This checklist is used to make sure that common guidelines for a pull request are followed.

Please add REST spec PR link to the SDK PR
I have read the contribution guidelines.
The pull request does not introduce breaking changes.

General Guidelines

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

Pull request includes test coverage for the included changes.

SDK Generation Guidelines

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

Csharp SDK for Microsoft.StorageSync Resource Provider

dsgouda

left a few comments

src/SDKs/StorageSync/Management.StorageSync/Microsoft.Azure.Management.StorageSync.csproj

src/SDKs/StorageSync/Management.StorageSync/Microsoft.Azure.Management.StorageSync.sln

src/SDKs/StorageSync/Management.StorageSync/Microsoft.Azure.Management.StorageSync.csproj

dsgouda · 2018-08-31T20:01:29Z

src/SDKs/StorageSync/Management.StorageSync/Generated/SdkInfo_MicrosoftStorageSync.cs

+        public static readonly String GithubCommidId = "7b95fd70c37943bd88eac39b3e7f1e4d4ab295ed";
+        public static readonly String CodeGenerationErrors = "";
+        public static readonly String GithubRepoName = "azure-rest-api-specs";
+        // END: Code Generation Metadata Section  }


Either regenerate the code or remove the } at the end of this line

dsgouda · 2018-08-31T20:02:25Z

src/SDKs/_metadata/storagesync_resource-manager.txt

@@ -0,0 +1 @@
+


Please pull latest changes from remote psSdkJson6, run msbuild build.proj and regenerate the code

… into storagesync-addsdk

dsgouda · 2018-08-31T20:10:39Z

Also, please link the REST spec PR here

ankushbindlish2 · 2018-08-31T20:11:54Z

https://github.com/Azure/azure-rest-api-specs/blob/master/specification/storagesync/resource-manager/readme.md

dsgouda · 2018-09-04T18:08:10Z

src/SDKs/StorageSync/Management.StorageSync/generate.ps1

@@ -0,0 +1,2 @@
+Start-AutoRestCodeGeneration -ResourceProvider "storagesync/resource-manager" -AutoRestVersion "latest" 
+#Start-AutoRestCodeGenerationWithLocalConfig -ResourceProvider "storagesync/resource-manager" -AutoRestVersion "latest" -LocalConfigFilePath "H:\csharpsdk\azure-rest-api-specs\specification\storagesync\resource-manager\readme.md" -SdkDirectory "H:\csharpsdk\azure-sdk-for-net\src\SDKs\StorageSync\Management.StorageSync\Generated"


You can remove this line

dsgouda · 2018-09-04T18:08:24Z

src/SDKs/StorageSync/StorageSync.Tests/StorageSync.Tests.csproj

+    <AssemblyName>StorageSync.Tests</AssemblyName>
+    <Description>StorageSync.Tests Class Library</Description>
+  </PropertyGroup>
+  <!--<PropertyGroup>


Remove these commented lines

dsgouda · 2018-09-04T22:30:48Z

src/SDKs/StorageSync/StorageSync.Tests/StorageSync.Tests.csproj

+  <Import Project="$([MSBuild]::GetPathOfFileAbove('AzSdk.test.reference.props'))" />
+  <PropertyGroup>
+    <PackageId>StorageSync.Tests</PackageId>
+    <VersionPrefix>1.0.0-preview</VersionPrefix>


Please replace this with <Version>1.0.0<Version>

Added tests.

ankushbindlish2 · 2018-09-11T05:23:46Z

@dsgouda I updated swagger to introduce some types like create and update parameters
Azure/azure-rest-api-specs#3863

dsgouda

Running generate.ps1 also generates a .txt file please check in this file too

src/SDKs/StorageSync/Management.StorageSync/generate.ps1

src/SDKs/StorageSync/StorageSync.Tests/Microsoft.Azure.Management.StorageSync.Tests.csproj

shahabhijeet · 2018-09-11T18:33:15Z

@ankushbindlish2 please always include link to the spec PR. Having a PR link helps rather than the commit.

src/SDKs/StorageSync/Management.StorageSync/AzSdk.RP.props

shahabhijeet

once the CI passes, this is good to be merged.

Csharp SDK for Microsoft.StorageSync Resource Provider

7cebb64

Csharp SDK for Microsoft.StorageSync Resource Provider

dsgouda suggested changes Aug 31, 2018

View reviewed changes

dsgouda added the Changes Requested label Aug 31, 2018

ankushbindlish2 added 2 commits August 31, 2018 13:04

Merge branch 'psSdkJson6' of https://github.com/Azure/azure-sdk-for-net…

07be662

… into storagesync-addsdk

Generated files

5bd0dd4

dsgouda added the Do Not Merge label Aug 31, 2018

Review comments

fb6d1b7

dsgouda suggested changes Sep 4, 2018

View reviewed changes

ankushbindlish2 added 2 commits September 7, 2018 17:25

Update after added first test

28f5b15

Added tests.

ab8b3d5

Added tests.

dsgouda suggested changes Sep 11, 2018

View reviewed changes

dsgouda removed the Do Not Merge label Sep 11, 2018

Review Comments

235bf38

shahabhijeet suggested changes Sep 11, 2018

View reviewed changes

src/SDKs/StorageSync/Management.StorageSync/AzSdk.RP.props Outdated Show resolved Hide resolved

ankushbindlish2 added 3 commits September 11, 2018 12:46

remove redundant file

28bdefc

Fix Registered class

27ed240

Generated with public swagger spec

26e18c0

ankushbindlish2 changed the title ~~Csharp SDK for Microsoft.StorageSync Resource Provider~~ Csharp SDK for Microsoft.StorageSync Resource Provider for ApiVersion package-2018-04-02 Sep 18, 2018

shahabhijeet approved these changes Sep 18, 2018

View reviewed changes

shahabhijeet merged commit 4310b58 into Azure:psSdkJson6 Sep 18, 2018

		@@ -0,0 +1,2 @@
		Start-AutoRestCodeGeneration -ResourceProvider "storagesync/resource-manager" -AutoRestVersion "latest"
		#Start-AutoRestCodeGenerationWithLocalConfig -ResourceProvider "storagesync/resource-manager" -AutoRestVersion "latest" -LocalConfigFilePath "H:\csharpsdk\azure-rest-api-specs\specification\storagesync\resource-manager\readme.md" -SdkDirectory "H:\csharpsdk\azure-sdk-for-net\src\SDKs\StorageSync\Management.StorageSync\Generated"

Comments

Conversation

ankushbindlish2 commented Aug 31, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

dsgouda left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dsgouda commented Aug 31, 2018

Uh oh!

ankushbindlish2 commented Aug 31, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ankushbindlish2 commented Sep 11, 2018

Uh oh!

dsgouda left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shahabhijeet commented Sep 11, 2018

Uh oh!

Uh oh!

shahabhijeet left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ankushbindlish2 commented Aug 31, 2018 •

edited

Loading