Add creation parameters to StorageSync ResourceProvider for SDK#3863
Add creation parameters to StorageSync ResourceProvider for SDK#3863marstr merged 3 commits intoAzure:masterfrom ankushbindlish2:storagesync-createparameters-for-sdk
Conversation
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
|
Can one of the admins verify this patch? |
Automation for azure-sdk-for-rubyNothing to generate for azure-sdk-for-ruby |
Automation for azure-sdk-for-goNothing to generate for azure-sdk-for-go |
Automation for azure-sdk-for-javaNothing to generate for azure-sdk-for-java |
Automation for azure-sdk-for-nodeThe initial PR has been merged into your service PR: |
marstr
left a comment
There was a problem hiding this comment.
Changing the names of these types will change the names that are generated. These alone represent substantial breaking changes. Not to mention, in many places (like the one example I've tagged), there are serious differences in what is documented as available via the API.
Almost all of this should be being done in a new API Version.
...cation/storagesync/resource-manager/Microsoft.StorageSync/stable/2018-04-02/storagesync.json
Show resolved
Hide resolved
KrisBash
left a comment
There was a problem hiding this comment.
Signing off from ARM on the condition that this is just aligning swagger to existing API. If there are any corresponding service changes, this should be a new API version/review.
marstr
left a comment
There was a problem hiding this comment.
After chatting offline with @ankushbindlish2, we've agreed that these breaking changes are necessary to drive conformance with the behavior of the service. Further more, he's provided evidence of testing these API Specs.
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger