Skip to content

Add creation parameters to StorageSync ResourceProvider for SDK#3863

Merged
marstr merged 3 commits intoAzure:masterfrom
ankushbindlish2:storagesync-createparameters-for-sdk
Sep 17, 2018
Merged

Add creation parameters to StorageSync ResourceProvider for SDK#3863
marstr merged 3 commits intoAzure:masterfrom
ankushbindlish2:storagesync-createparameters-for-sdk

Conversation

@ankushbindlish2
Copy link
Member

@ankushbindlish2 ankushbindlish2 commented Sep 11, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Sep 11, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2734

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Sep 11, 2018

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Sep 11, 2018

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@AutorestCI
Copy link

AutorestCI commented Sep 11, 2018

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI
Copy link

AutorestCI commented Sep 11, 2018

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3622

@marstr marstr added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required potential-sdk-breaking-change labels Sep 12, 2018
Copy link
Member

@marstr marstr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the names of these types will change the names that are generated. These alone represent substantial breaking changes. Not to mention, in many places (like the one example I've tagged), there are serious differences in what is documented as available via the API.

Almost all of this should be being done in a new API Version.

Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signing off from ARM on the condition that this is just aligning swagger to existing API. If there are any corresponding service changes, this should be a new API version/review.

@KrisBash KrisBash removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 13, 2018
Copy link
Member

@marstr marstr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After chatting offline with @ankushbindlish2, we've agreed that these breaking changes are necessary to drive conformance with the behavior of the service. Further more, he's provided evidence of testing these API Specs.

@marstr marstr merged commit 03757d2 into Azure:master Sep 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments