Re-generated Network for August release#4675
Re-generated Network for August release#4675anton-evseev wants to merge 4 commits intoAzure:psSdkJson6from
Conversation
dsgouda
left a comment
dsgouda
left a comment
There was a problem hiding this comment.
Looks great for the most part, need some questions answered
| <Description>Provides management capabilities for Network services.</Description> | ||
| <AssemblyName>Microsoft.Azure.Management.Network</AssemblyName> | ||
| <Version>19.2.0-preview</Version> | ||
| <Version>20.0.0-preview</Version> |
There was a problem hiding this comment.
@MikhailTryakhov any word on when you are planning to release a stable version here? Any reason why you plan to do a major version bump here
There was a problem hiding this comment.
@dsgouda I think we need publish stable version when all know issues will be fixed. now we have one in brooklyn team. let's I test all swagger issues we have (in optional jobs for example), fix them and next Ignite version will be stable
There was a problem hiding this comment.
if you are in preview you cannot bump up major version
| } | ||
| } | ||
|
|
||
| [Fact(Skip="Disable tests")] |
There was a problem hiding this comment.
Why are these being deleted? Was this service deprecated?
There was a problem hiding this comment.
OutboundNatRules were never made public
Azure/azure-rest-api-specs#3592
There was a problem hiding this comment.
Specific comment: Azure/azure-rest-api-specs#3592 (comment)
| <Description>Provides management capabilities for Network services.</Description> | ||
| <AssemblyName>Microsoft.Azure.Management.Network</AssemblyName> | ||
| <Version>19.2.0-preview</Version> | ||
| <Version>20.0.0-preview</Version> |
There was a problem hiding this comment.
if you are in preview you cannot bump up major version
|
@shahabhijeet @dsgouda set file version to |
|
@shahabhijeet any additional feedback? |
|
close because waiting for changes in LB |
|
I'll update this PR once LB changes (Azure/azure-rest-api-specs#3697) are merged in |
|
Closing PR per @MikhailTryakhov 's comment |
|
@number213 Feel free to open a new PR when you are ready, I'll be happy to take a look |
4 participants
Description
Based on: Azure/azure-rest-api-specs#3635
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.