Mark outbound rule properties as required#3697
Mark outbound rule properties as required#3697khannarhea wants to merge 1 commit intoAzure:Network-September-Releasefrom
Conversation
|
Can one of the admins verify this patch? |
Automation for azure-sdk-for-rubyNothing to generate for azure-sdk-for-ruby |
Automation for azure-sdk-for-pythonA PR has been created for you: |
Automation for azure-sdk-for-nodeA PR has been created for you: |
Automation for azure-sdk-for-goNothing to generate for azure-sdk-for-go |
Automation for azure-sdk-for-javaNothing to generate for azure-sdk-for-java |
|
@khannarhea looks good to me. |
|
@christiankuhtz @khannarhea this is a breaking change. by some reason SDK is still not releseased and we'll include this info there. but next time it'll be very bad to push such changes in next SDK version it'll cause problems. Can we be sure your swagger is ready? |
|
@khannarhea please push changes to |
| } | ||
| }, | ||
| "required": [ | ||
| "backendAddressPool" |
There was a problem hiding this comment.
@khannarhea @MikhailTryakhov why the changes for 2018-07-01 are targeting September branch (2018-08-01)? IMHO, it should target master.
There was a problem hiding this comment.
@sergey-shandar you're right. @khannarhea please retarget it to master branch
|
I'm closing this PR in favor of #3711 |
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger