Skip to content

Mark outbound rule properties as required#3697

Closed
khannarhea wants to merge 1 commit intoAzure:Network-September-Releasefrom
khannarhea:Network-September-Release
Closed

Mark outbound rule properties as required#3697
khannarhea wants to merge 1 commit intoAzure:Network-September-Releasefrom
khannarhea:Network-September-Release

Conversation

@khannarhea
Copy link
Contributor

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Aug 21, 2018

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Aug 21, 2018

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#3180

@AutorestCI
Copy link

AutorestCI commented Aug 21, 2018

Automation for azure-sdk-for-node

A PR has been created for you:
Azure/azure-sdk-for-node#3392

@AutorestCI
Copy link

AutorestCI commented Aug 21, 2018

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@AutorestCI
Copy link

AutorestCI commented Aug 21, 2018

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@christiankuhtz
Copy link

@khannarhea looks good to me.

@MikhailTryakhov
Copy link
Contributor

@christiankuhtz @khannarhea this is a breaking change. by some reason SDK is still not releseased and we'll include this info there. but next time it'll be very bad to push such changes in next SDK version it'll cause problems. Can we be sure your swagger is ready?

@MikhailTryakhov
Copy link
Contributor

@khannarhea please push changes to master branch as well to avoid breaking changes in SDKs

}
},
"required": [
"backendAddressPool"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khannarhea @MikhailTryakhov why the changes for 2018-07-01 are targeting September branch (2018-08-01)? IMHO, it should target master.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sergey-shandar you're right. @khannarhea please retarget it to master branch

@sergey-shandar
Copy link
Contributor

sergey-shandar commented Aug 23, 2018

I'm closing this PR in favor of #3711

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants