Skip to content

All credentials have parameterless ctor #43962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christothes merged 2 commits into from
May 15, 2024
Merged

All credentials have parameterless ctor #43962

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49d0970
All credentials have parameterless ctor
christothes May 9, 2024
2eea62b
export
christothes May 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions sdk/identity/Azure.Identity/api/Azure.Identity.netstandard2.0.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ public BrowserCustomizationOptions() { }
}
public partial class ChainedTokenCredential : Azure.Core.TokenCredential
{
protected ChainedTokenCredential() { }
public ChainedTokenCredential(params Azure.Core.TokenCredential[] sources) { }
public override Azure.Core.AccessToken GetToken(Azure.Core.TokenRequestContext requestContext, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
public override System.Threading.Tasks.ValueTask<Azure.Core.AccessToken> GetTokenAsync(Azure.Core.TokenRequestContext requestContext, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
Expand Down Expand Up @@ -180,6 +181,7 @@ public CredentialUnavailableException(string message, System.Exception innerExce
}
public partial class DefaultAzureCredential : Azure.Core.TokenCredential
{
protected DefaultAzureCredential() { }
public DefaultAzureCredential(Azure.Identity.DefaultAzureCredentialOptions options) { }
public DefaultAzureCredential(bool includeInteractiveCredentials = false) { }
public override Azure.Core.AccessToken GetToken(Azure.Core.TokenRequestContext requestContext, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
Expand Down
4 changes: 2 additions & 2 deletions sdk/identity/Azure.Identity/src/Credentials/ChainedTokenCredential.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@ public class ChainedTokenCredential : TokenCredential
private readonly TokenCredential[] _sources;

/// <summary>
/// Constructor for instrumenting in tests
/// Protected constructor for <see href="https://aka.ms/azsdk/net/mocking">mocking</see>.
/// </summary>
internal ChainedTokenCredential()
protected ChainedTokenCredential()
{
_sources = Array.Empty<TokenCredential>();
}
Expand Down
5 changes: 4 additions & 1 deletion sdk/identity/Azure.Identity/src/Credentials/DefaultAzureCredential.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,10 @@ public class DefaultAzureCredential : TokenCredential

internal TokenCredential[] _sources;

internal DefaultAzureCredential() : this(false) { }
/// <summary>
/// Protected constructor for <see href="https://aka.ms/azsdk/net/mocking">mocking</see>.
/// </summary>
protected DefaultAzureCredential() : this(false) { }

/// <summary>
/// Creates an instance of the DefaultAzureCredential class.
Expand Down
3 changes: 2 additions & 1 deletion sdk/identity/Azure.Identity/tests/AzurePipelinesCredentialTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@ public override TokenCredential GetTokenCredential(CommonCredentialTestConfig co
PlanId = "myplan",
JobId = "myjob",
TeamProjectId = "myteamproject",
SystemAccessToken = "mytoken"
SystemAccessToken = "mytoken",
HubName = "myhub",
Comment thread
christothes marked this conversation as resolved.
};
if (config.Transport != null)
{
Expand Down