Skip to content

All credentials have parameterless ctor#43962

Merged
christothes merged 2 commits intoAzure:mainfrom
christothes:chriss/creds_mockable
May 15, 2024
Merged

All credentials have parameterless ctor#43962
christothes merged 2 commits intoAzure:mainfrom
christothes:chriss/creds_mockable

Conversation

@christothes
Copy link
Copy Markdown
Member

closes #43959

@azure-sdk
Copy link
Copy Markdown
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

Azure.Identity

Copy link
Copy Markdown
Member

@scottaddie scottaddie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this protected, parameterless ctor also be added to credential types like Workload Identity and VS?

Comment thread sdk/identity/Azure.Identity/tests/AzurePipelinesCredentialTests.cs
@christothes christothes merged commit 9637250 into Azure:main May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

Make all credential types mockable

4 participants