Skip to content

Read registry only from windows os #4364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsgouda merged 2 commits into from
Jun 1, 2018
Merged

Read registry only from windows os #4364

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2e6ec3
Read registry only from windows os
dsgouda May 24, 2018
17178c4
Merge branch 'psSdkJson6' into i4263
shahabhijeet May 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/SdkCommon/ClientRuntime/ClientRuntime/ServiceClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,14 @@ private string OsVersion
/// <returns>Value for provided HKLM key</returns>
private string ReadHKLMRegistry(string path, string key)
{
switch (Environment.OSVersion.Platform)
Copy link
Copy Markdown
Contributor

@shahabhijeet shahabhijeet May 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsgouda let's test this on mono/non-windows to make sure this does not throw runtime exceptions.

{
case PlatformID.Unix:
case PlatformID.MacOSX:
case PlatformID.Xbox:
return string.Empty;
}

try
{
using (RegistryKey rk = Registry.LocalMachine.OpenSubKey(path))
Expand Down