Skip to content

Read registry only from windows os#4364

Merged
dsgouda merged 2 commits intoAzure:psSdkJson6from
dsgouda:i4263
Jun 1, 2018
Merged

Read registry only from windows os#4364
dsgouda merged 2 commits intoAzure:psSdkJson6from
dsgouda:i4263

Conversation

@dsgouda
Copy link
Copy Markdown
Contributor

@dsgouda dsgouda commented May 24, 2018

Addressing issue #4263
Some relevant information here

Description


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@dsgouda dsgouda requested a review from shahabhijeet May 24, 2018 18:38
/// <returns>Value for provided HKLM key</returns>
private string ReadHKLMRegistry(string path, string key)
{
switch (Environment.OSVersion.Platform)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsgouda let's test this on mono/non-windows to make sure this does not throw runtime exceptions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants