Merged
Conversation
TimothyMothra
requested review from
KrzysztofCwalina and
tg-msft
as code owners
Member
Can you get other PR merged and update the APIs. I don't think we should add more APIs and then remove it. |
Author
This is not adding a new API. This API has already shipped in our last beta. |
rajkumar-rangaraj
approved these changes
Mar 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #42426
our APIs are out of sync.
when I added net6 to these projects, I should have regenerated the api.
The following changes are from running
eng\scripts\Export-API.ps1 monitorChanges
net6api file forNote
The LiveMetrics api is showing extra public classes. Ignore this for now, all of this will go away in my other PR updating the swagger.
THIS PR is focused on getting our build compliant again.