Azure.Monitor: fix for Microsoft.Bcl.AsyncInterfaces#42426
Merged
TimothyMothra merged 10 commits intomainfrom Mar 7, 2024
Merged
Azure.Monitor: fix for Microsoft.Bcl.AsyncInterfaces#42426TimothyMothra merged 10 commits intomainfrom
TimothyMothra merged 10 commits intomainfrom
Conversation
github-actions
bot
added
Monitor - Distro
Collaborator
|
API change check API changes are not detected in this pull request. |
TimothyMothra
requested review from
cijothomas,
rajkumar-rangaraj,
reyang,
vishweshbankwar and
xiang17
as code owners
...tCore/src/Vendoring/Shared/EnvironmentVariables/EnvironmentVariablesConfigurationProvider.cs
Outdated
Show resolved
Hide resolved
xiang17
reviewed
Mar 7, 2024
...or/Azure.Monitor.OpenTelemetry.LiveMetrics/src/Internals/Filtering/FilterConjunctionGroup.cs
Outdated
Show resolved
Hide resolved
xiang17
reviewed
Mar 7, 2024
TimothyMothra
commented
Mar 7, 2024
sdk/monitor/Azure.Monitor.OpenTelemetry.LiveMetrics/src/Internals/Filtering/DerivedMetric.cs
Show resolved
Hide resolved
TimothyMothra
commented
Mar 7, 2024
...or/Azure.Monitor.OpenTelemetry.LiveMetrics/src/Internals/Filtering/FilterConjunctionGroup.cs
Show resolved
Hide resolved
TimothyMothra
commented
Mar 7, 2024
sdk/monitor/Azure.Monitor.OpenTelemetry.LiveMetrics/src/Internals/Filtering/DerivedMetric.cs
Show resolved
Hide resolved
rajkumar-rangaraj
approved these changes
Mar 7, 2024
angiurgiu
pushed a commit
that referenced
this pull request
Mar 20, 2024
* add net6 to AspNetCore and LiveMetrics * fix compiler issues * test removing bcl fix from test/demo projects * fix compiler issues in LiveMetrics * changelog * re-enable nullable in Filter classes * update error message * revert
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #42360, #41747
This PR is a fix for a runtime crash.
This is related to projects referencing either Distro or LiveMetrics, which references
netstandard2.0and Exporter which referencesnet6. Runtime looks for a newer version of Microsoft.Bcl.AsyncInterfaces and crashes.Changes
net6toAzure.Monitor.OpenTelemetry.AspNetCoreandAzure.Monitor.OpenTelemetry.LiveMetrics.This brings both projects in sync with
Azure.Monitor.OpenTelemetry.Exporter.AspNetCoreandLiveMetricsprojects discovered by the newer framework.Microsoft.Bcl.AsyncInterfacesfrom our Test and Demo projects.