[Storage] Support Locationusage and WORM (Immutability Policy) and upgrade API version to 2018-02-01 #4289
Conversation
67cc6a4 to
6376243
Compare
|
I have rebase my code on the latest change on "psSdkJson6" branch and run For the tight schedule, I have set up a meeting to discuss the PR if it's still not merged tomorrow. |
dsgouda
left a comment
There was a problem hiding this comment.
Looks good apart from the comment posted. Will merge the PR once addressed.
| { | ||
| return new Tuple<string, string, string>[] | ||
| { | ||
| new Tuple<string, string, string>("Storage", "BlobContainers", "2018-02-01"), |
There was a problem hiding this comment.
Please replace line 4 with <AzureApiTag>Storage_2018-02-01;</AzureApiTag> here
There was a problem hiding this comment.
I have fixed it.
I think this should be automatically updated when build. Do I miss anything to update it? Or is there any code error in SDK framework make this not update in build?
There was a problem hiding this comment.
It should be but not sure why it fails, better do this manually since this is a rush job
dsgouda
left a comment
There was a problem hiding this comment.
LGTM subject to CI builds
Description
This is target to release on 5/7 build.
Since the tight schedule, please help to review ASAP.
The private PR pass check: https://github.com/Azure/azure-sdk-for-net-pr/pull/833
The unit test is modified by removing disable Storage Account Encryption test. Since server doesn't allow disable encryption now.
The swagger PR:
WORM: Azure/azure-rest-api-specs#2937
Location Usage: Azure/azure-rest-api-specs#3014 (in review)
The Rest Doc:
WORM: https://microsoft.sharepoint.com/teams/AzureStorage/Shared%20Documents/XLocation/SRP%20Service%20and%20Container%20Management.docx?web=1
Location Usage:
https://microsoft.sharepoint.com/:w:/t/AzureStorage/EYFU1AAlf3BBqV6C28ajBB0BpOXZDKOfZYnoQnZOU6wivA?e=uP50YO (See get location usage API section)
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.