Skip to content

[Storage] Support Locationusage and WORM (Immutability Policy) and upgrade API version to 2018-02-01 #4289

Merged
dsgouda merged 11 commits intoAzure:psSdkJson6from
blueww:locationusage
May 8, 2018
Merged

[Storage] Support Locationusage and WORM (Immutability Policy) and upgrade API version to 2018-02-01 #4289
dsgouda merged 11 commits intoAzure:psSdkJson6from
blueww:locationusage

Conversation

@blueww
Copy link
Member

@blueww blueww commented May 7, 2018

Description

This is target to release on 5/7 build.
Since the tight schedule, please help to review ASAP.

The private PR pass check: https://github.com/Azure/azure-sdk-for-net-pr/pull/833

The unit test is modified by removing disable Storage Account Encryption test. Since server doesn't allow disable encryption now.

The swagger PR:
WORM: Azure/azure-rest-api-specs#2937
Location Usage: Azure/azure-rest-api-specs#3014 (in review)

The Rest Doc:
WORM: https://microsoft.sharepoint.com/teams/AzureStorage/Shared%20Documents/XLocation/SRP%20Service%20and%20Container%20Management.docx?web=1
Location Usage:
https://microsoft.sharepoint.com/:w:/t/AzureStorage/EYFU1AAlf3BBqV6C28ajBB0BpOXZDKOfZYnoQnZOU6wivA?e=uP50YO (See get location usage API section)


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@blueww blueww changed the title [Don't merge][Storage] Support Locationusage and WORM (Immutability Policy) and upgrade API version to 2018-02-01 [Storage] Support Locationusage and WORM (Immutability Policy) and upgrade API version to 2018-02-01 May 7, 2018
@blueww blueww force-pushed the locationusage branch 2 times, most recently from 67cc6a4 to 6376243 Compare May 7, 2018 05:25
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please run msbuild build.proj /t:Build /p:Scope=SDKs\Storage and commit any artifacts that may change
  • Please create a generate.ps1 file similar to this and regenerate the code

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7.2.0-preview

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@blueww
Copy link
Member Author

blueww commented May 8, 2018

@dsgouda

I have rebase my code on the latest change on "psSdkJson6" branch and run msbuild build.proj /t:Build /p:Scope=SDKs\Storage, but don't see anything change.
I have created the generate.ps1 file and add to the PR.

For the tight schedule, I have set up a meeting to discuss the PR if it's still not merged tomorrow.
We can cancel it if the PR is merged before the meeting.

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from the comment posted. Will merge the PR once addressed.

{
return new Tuple<string, string, string>[]
{
new Tuple<string, string, string>("Storage", "BlobContainers", "2018-02-01"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace line 4 with <AzureApiTag>Storage_2018-02-01;</AzureApiTag> here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have fixed it.
I think this should be automatically updated when build. Do I miss anything to update it? Or is there any code error in SDK framework make this not update in build?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be but not sure why it fails, better do this manually since this is a rush job

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM subject to CI builds

@dsgouda dsgouda merged commit ac98ee8 into Azure:psSdkJson6 May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments