Azure Storage 2018-02-01 by JasonYang-MSFT · Pull Request #2937 · Azure/azure-rest-api-specs

JasonYang-MSFT · 2018-04-24T10:58:09Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

Related PR: https://github.com/Azure/azure-rest-api-specs-pr/pull/447

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

AutorestCI · 2018-04-24T10:59:47Z

Automation for azure-libraries-for-java

The initial PR has been merged into your service PR:
AutorestCI/azure-libraries-for-java#114

AutorestCI · 2018-04-24T10:59:49Z

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#2796

azuresdkciprbot · 2018-04-24T11:02:20Z

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/storage/resource-manager/readme.md

⚠️

0 new Warnings.(2 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-04-24T11:02:20Z

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/storage/resource-manager/readme.md

⚠️

0 new Warnings.(3 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

AutorestCI · 2018-04-24T11:05:03Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2471

AutorestCI · 2018-04-24T11:06:49Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#1703

jianghaolu · 2018-04-24T20:52:56Z

specification/common/AzureResource.json

What's the reason of adding these? We already have some of these common types defined here: https://github.com/Azure/azure-rest-api-specs/blob/master/specification/common-types/resource-management/v1/types.json

Fixed. And move the AzureEntityResource to type.json.

jianghaolu · 2018-04-24T20:53:41Z

specification/common/Parameters.json

These are available here too: https://github.com/Azure/azure-rest-api-specs/blob/master/specification/common-types/resource-management/v1/types.json#L258.

Fixed. But since the "ResourceGroupNameParameter" defined in https://github.com/Azure/azure-rest-api-specs/blob/master/specification/common-types/resource-management/v1/types.json, has "x-ms-parameter-location": "client", which will take breaking change to storage SDK, I define it in storage.json. We can revert to use common type when the definition difference of "ResourceGroupNameParameter" is resolved.

…ment/v1/types.json

azuresdkciprbot · 2018-04-25T06:13:32Z

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/storage/resource-manager/readme.md

⚠️

0 new Warnings.(3 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-04-25T06:13:32Z

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/storage/resource-manager/readme.md

⚠️

0 new Warnings.(3 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

blueww · 2018-04-25T06:14:02Z

@jianghaolu
I have fixed as your comments. But the "ResourceGroupNameParameter" in type.json is defined different with origin one on "x-ms-parameter-location": "client", which will take breaking to storage SDK.
So I don't use it in type.json, but define in storage.json.

Since the release of this feature is in a tight schedule, I will setup a meeting tomorrow in case the PR still has some comments need to follow.

azuresdkciprbot · 2018-04-25T07:06:21Z

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/storage/resource-manager/readme.md

⚠️

0 new Warnings.(0 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-04-25T07:06:21Z

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/storage/resource-manager/readme.md

⚠️

0 new Warnings.(0 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-04-25T07:11:22Z

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/storage/resource-manager/readme.md

⚠️

0 new Warnings.(3 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-04-25T07:11:22Z

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/storage/resource-manager/readme.md

⚠️

0 new Warnings.(3 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

blueww · 2018-04-25T07:43:32Z

@jianghaolu
The build check failed. But seems not caused by my code change?
Could you please help to look?

azuresdkciprbot · 2018-04-25T09:05:45Z

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/storage/resource-manager/readme.md

⚠️

0 new Warnings.(3 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-04-25T09:05:45Z

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/storage/resource-manager/readme.md

⚠️

0 new Warnings.(3 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

…e the common one has input it from client, which is breaking

azuresdkciprbot · 2018-04-25T09:27:32Z

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/storage/resource-manager/readme.md

⚠️

0 new Warnings.(3 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-04-25T09:27:32Z

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/storage/resource-manager/readme.md

⚠️

0 new Warnings.(3 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkci assigned jianghaolu Apr 24, 2018

azuresdkci requested a review from jianghaolu April 24, 2018 10:59

AutorestCI mentioned this pull request Apr 24, 2018

[AutoPR storage/resource-manager] Azure Storage 2018-02-01 AutorestCI/azure-libraries-for-java#111

Merged

AutorestCI mentioned this pull request Apr 24, 2018

[AutoPR storage/resource-manager] Azure Storage 2018-02-01 Azure/azure-sdk-for-node#2787

Merged

AutorestCI mentioned this pull request Apr 24, 2018

[AutoPR storage/resource-manager] Azure Storage 2018-02-01 Azure/azure-sdk-for-python#2458

Merged

AutorestCI mentioned this pull request Apr 24, 2018

[AutoPR storage/resource-manager] Azure Storage 2018-02-01 Azure/azure-sdk-for-go#1690

Merged

jianghaolu reviewed Apr 24, 2018

View reviewed changes

blueww and others added 7 commits April 25, 2018 11:31

[Storage] Add rest version 2018-02-01

54dc19e

[Storage] Add storage blob API

fe1e327

[Storage] Update Example for ContainerAPI

bfed3b4

Add multi-api configuration

45a747a

[Storage] Update Example for ContainerAPI

d4d6c1c

[Storage] Set LegalHold Tags as required

d7116be

[Storage] use the common type defined in common-types/resource-manage…

284ebbb

…ment/v1/types.json

blueww force-pushed the containerapi2018-02-01 branch from 5e65907 to 45ac137 Compare April 25, 2018 06:07

blueww force-pushed the containerapi2018-02-01 branch from 45ac137 to d3205ab Compare April 25, 2018 07:01

blueww force-pushed the containerapi2018-02-01 branch from d3205ab to e8f30fe Compare April 25, 2018 07:06

blueww force-pushed the containerapi2018-02-01 branch from e8f30fe to c1888cc Compare April 25, 2018 09:00

[Storage] revert to use REsourceGroup defined in storage swagger sinc…

63f725f

…e the common one has input it from client, which is breaking

blueww force-pushed the containerapi2018-02-01 branch from c1888cc to 63f725f Compare April 25, 2018 09:23

jianghaolu approved these changes Apr 26, 2018

View reviewed changes

jianghaolu merged commit 585db62 into Azure:master Apr 26, 2018

blueww mentioned this pull request May 7, 2018

[Storage] Support Locationusage and WORM (Immutability Policy) and upgrade API version to 2018-02-01 Azure/azure-sdk-for-net#4289

Merged

9 tasks

Conversation

JasonYang-MSFT commented Apr 24, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR information

Quality of Swagger

Uh oh!

AutorestCI commented Apr 24, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-libraries-for-java

Uh oh!

AutorestCI commented Apr 24, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-node

Uh oh!

azuresdkciprbot commented Apr 24, 2018

AutoRest linter results for SDK Related Validation Errors/Warnings

Uh oh!

azuresdkciprbot commented Apr 24, 2018

AutoRest linter results for ARM Related Validation Errors/Warnings

Uh oh!

AutorestCI commented Apr 24, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented Apr 24, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

jianghaolu Apr 24, 2018

Choose a reason for hiding this comment

Uh oh!

blueww Apr 25, 2018

Choose a reason for hiding this comment

Uh oh!

jianghaolu Apr 24, 2018

Choose a reason for hiding this comment

Uh oh!

blueww Apr 25, 2018

Choose a reason for hiding this comment

Uh oh!

azuresdkciprbot commented Apr 25, 2018

AutoRest linter results for ARM Related Validation Errors/Warnings

Uh oh!

azuresdkciprbot commented Apr 25, 2018

AutoRest linter results for SDK Related Validation Errors/Warnings

Uh oh!

blueww commented Apr 25, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

azuresdkciprbot commented Apr 25, 2018

AutoRest linter results for SDK Related Validation Errors/Warnings

Uh oh!

azuresdkciprbot commented Apr 25, 2018

AutoRest linter results for ARM Related Validation Errors/Warnings

Uh oh!

azuresdkciprbot commented Apr 25, 2018

AutoRest linter results for ARM Related Validation Errors/Warnings

Uh oh!

azuresdkciprbot commented Apr 25, 2018

AutoRest linter results for SDK Related Validation Errors/Warnings

Uh oh!

blueww commented Apr 25, 2018

Uh oh!

azuresdkciprbot commented Apr 25, 2018

AutoRest linter results for ARM Related Validation Errors/Warnings

Uh oh!

azuresdkciprbot commented Apr 25, 2018

AutoRest linter results for SDK Related Validation Errors/Warnings

Uh oh!

azuresdkciprbot commented Apr 25, 2018

AutoRest linter results for SDK Related Validation Errors/Warnings

Uh oh!

azuresdkciprbot commented Apr 25, 2018

AutoRest linter results for ARM Related Validation Errors/Warnings

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

JasonYang-MSFT commented Apr 24, 2018 •

edited

Loading

AutorestCI commented Apr 24, 2018 •

edited

Loading

AutorestCI commented Apr 24, 2018 •

edited

Loading

AutorestCI commented Apr 24, 2018 •

edited

Loading

AutorestCI commented Apr 24, 2018 •

edited

Loading

blueww commented Apr 25, 2018 •

edited

Loading