Skip to content

Updating Language/Language SDK with new /entities endpoint#4286

Merged
dsgouda merged 5 commits intoAzure:psSdkJson6from
assafi:assafi/old_ta_sdk
May 7, 2018
Merged

Updating Language/Language SDK with new /entities endpoint#4286
dsgouda merged 5 commits intoAzure:psSdkJson6from
assafi:assafi/old_ta_sdk

Conversation

@assafi
Copy link
Contributor

@assafi assafi commented May 3, 2018 •
edited
Loading

Description

  • Update of existing TA SDK with new /entities endpoint and additional Azure regions.
  • The SDK will be deprecated and succeeded by Microsoft.Azure.CognitiveServices.Language.TextAnalytics NuGet. See new SDK PR.

Swagger spec PR

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@azuresdkci
Copy link
Contributor

azuresdkci commented May 3, 2018

Can one of the admins verify this patch?

3 similar comments
@azuresdkci
Copy link
Contributor

azuresdkci commented May 3, 2018

Can one of the admins verify this patch?

@azuresdkci
Copy link
Contributor

azuresdkci commented May 3, 2018

Can one of the admins verify this patch?

@azuresdkci
Copy link
Contributor

azuresdkci commented May 3, 2018

Can one of the admins verify this patch?

@dsgouda
Copy link
Contributor

dsgouda commented May 4, 2018 •
edited
Loading

@assafi The PackageReleaseNotes here must be updated once the new package is published

@assafi
Copy link
Contributor Author

assafi commented May 4, 2018

@dsgouda The PackageReleaseNotes have been updated. What additional info would you like to see?

@dsgouda
Copy link
Contributor

dsgouda commented May 4, 2018

@assafi Once you publish Language.TextAnalytics package, note the link to that package and add it to the release notes here,

dsgouda
dsgouda reviewed May 7, 2018
View reviewed changes
...vices/dataPlane/Language/Language/Language/Microsoft.Azure.CognitiveServices.Language.csproj Outdated
<PropertyGroup>
<PackageId>Microsoft.Azure.CognitiveServices.Language</PackageId>
<Description>This client library provides access to the Microsoft Cognitive Services Language APIs.</Description>
<VersionPrefix>1.0.1-preview</VersionPrefix>
Copy link
Contributor

@dsgouda dsgouda May 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace VersionPrefix with Version

Copy link
Contributor Author

@assafi assafi May 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version already exists below.

dsgouda
dsgouda suggested changes May 7, 2018
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you able to generate the code using generate.cmd? please do if you can and commit all changes

...ane/Language/Language/Language.Tests/Microsoft.Azure.CognitiveServices.Language.Tests.csproj
@@ -3,11 +3,11 @@
<PropertyGroup>
<Description>Microsoft.Azure.CognitiveServices.Language.Tests Class Library</Description>
<AssemblyName>Microsoft.Azure.CognitiveServices.Language.Tests</AssemblyName>
Copy link
Contributor

@dsgouda dsgouda May 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no changes required to this file

@assafi
Copy link
Contributor Author

assafi commented May 7, 2018

For this SDK update I am not able to use the generate.ps1 since the namespace has changed. However, I've used the generated code from the new SDK and copied it over since it's exactly the same except for the project path. I just copied these changes over.

dsgouda
dsgouda approved these changes May 7, 2018
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dsgouda
dsgouda approved these changes May 7, 2018
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM will merge on CIs passing

@dsgouda dsgouda merged commit 2278bd5 into Azure:psSdkJson6 May 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dsgouda dsgouda dsgouda approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@assafi @azuresdkci @dsgouda