New Language/TextAnalytics SDK#4285
New Language/TextAnalytics SDK#4285shahabhijeet merged 5 commits intoAzure:psSdkJson6from assafi:assafi/new_ta_sdk
Conversation
|
Can one of the admins verify this patch? |
3 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
shahabhijeet
left a comment
There was a problem hiding this comment.
Please generate the sdk using generate.ps1
Doing this we are able to generate the meta data needed.
|
I did use |
dsgouda
left a comment
There was a problem hiding this comment.
Since this is a new project in a new directory it should be possible to add an assembly.cs here, let us know if you still run into issues
Also, when the code is generated using the ps1, a log txt file will be generated, please commit this file.
| <PropertyGroup> | ||
| <Description>Microsoft.Azure.CognitiveServices.Language.TextAnalytics.Tests Class Library</Description> | ||
| <AssemblyName>Microsoft.Azure.CognitiveServices.Language.TextAnalytics.Tests</AssemblyName> | ||
| <Version>1.0.1-preview</Version> |
There was a problem hiding this comment.
Please set the test projects version to 1.0.0, this is never published
There was a problem hiding this comment.
ok.. although I don't understand what's publishing has to do with it. The version of the test project has changed to confirm to the version of the tested project. If you feel strongly about it I'll change the version number.
(p.s. can anyone add versioning guidelines doc somewhere?)
There was a problem hiding this comment.
@dsgouda I just ran generate.ps1 again and I don't see any log file. Where can I find it?
dsgouda
left a comment
There was a problem hiding this comment.
LGTM subject to CI builds passing
| <PropertyGroup> | ||
| <PackageId>Microsoft.Azure.CognitiveServices.Language.TextAnalytics</PackageId> | ||
| <Description>This client library provides access to the Microsoft Cognitive Services Language APIs.</Description> | ||
| <VersionPrefix>1.0.1-preview</VersionPrefix> |
There was a problem hiding this comment.
@assafi please remove versionPrefix next time. Going to merge it this time.
Description
Microsoft.Azure.CognitiveServices.Language.**TextAnalytics**. This new SDK is the successor ofMicrosoft.Azure.CognitiveServices.Languagepackage which will get it's final update in an upcoming PR (specifying it upcoming deprecation).PR for corresponding swagger spec
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.