Skip to content

New Language/TextAnalytics SDK#4285

Merged
shahabhijeet merged 5 commits intoAzure:psSdkJson6from
assafi:assafi/new_ta_sdk
May 7, 2018
Merged

New Language/TextAnalytics SDK#4285
shahabhijeet merged 5 commits intoAzure:psSdkJson6from
assafi:assafi/new_ta_sdk

Conversation

@assafi
Copy link
Contributor

@assafi assafi commented May 3, 2018

Description

  • New TA SDK under a new name Microsoft.Azure.CognitiveServices.Language.**TextAnalytics**. This new SDK is the successor of Microsoft.Azure.CognitiveServices.Language package which will get it's final update in an upcoming PR (specifying it upcoming deprecation).
  • Initial SDK version is 1.0.1-preview - this is in order to confirm to the previous namespace SDK which final supported version will be 1.0.1-preview and will have the same features added as this one. (i.e. we'll have a version overlap and only a namespace change).
  • New endpoint includes a new TA endpoint (/entities) and expands the Azure region support (+7)

PR for corresponding swagger spec


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

3 similar comments
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

Copy link
Contributor

@shahabhijeet shahabhijeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please generate the sdk using generate.ps1
Doing this we are able to generate the meta data needed.

@assafi
Copy link
Contributor Author

assafi commented May 4, 2018

I did use generate.ps1 but had to delete the AssemblyInfo.cs because VS complained about duplicate attributes.

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a new project in a new directory it should be possible to add an assembly.cs here, let us know if you still run into issues
Also, when the code is generated using the ps1, a log txt file will be generated, please commit this file.

<PropertyGroup>
<Description>Microsoft.Azure.CognitiveServices.Language.TextAnalytics.Tests Class Library</Description>
<AssemblyName>Microsoft.Azure.CognitiveServices.Language.TextAnalytics.Tests</AssemblyName>
<Version>1.0.1-preview</Version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please set the test projects version to 1.0.0, this is never published

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok.. although I don't understand what's publishing has to do with it. The version of the test project has changed to confirm to the version of the tested project. If you feel strongly about it I'll change the version number.
(p.s. can anyone add versioning guidelines doc somewhere?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsgouda I just ran generate.ps1 again and I don't see any log file. Where can I find it?

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM subject to CI builds passing

<PropertyGroup>
<PackageId>Microsoft.Azure.CognitiveServices.Language.TextAnalytics</PackageId>
<Description>This client library provides access to the Microsoft Cognitive Services Language APIs.</Description>
<VersionPrefix>1.0.1-preview</VersionPrefix>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@assafi please remove versionPrefix next time. Going to merge it this time.

@shahabhijeet shahabhijeet merged commit 172be02 into Azure:psSdkJson6 May 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants