Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="xunit" Version="2.3.0-beta1-build3642" />
<PackageReference Include="xunit.runner.visualstudio" Version="2.3.0-beta1-build1309" />
<PackageReference Include="xunit" Version="2.3.1" />
<PackageReference Include="xunit.runner.visualstudio" Version="2.3.1" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.0.0-preview-20170222-09" />
<!-- <PackageReference Include="Microsoft.NETCore.App" Version="1.0.2" /> -->
</ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@
</ItemGroup>
<ItemGroup>
<PackageReference Include="Microsoft.AspNetCore.Server.WebListener" Version="1.0.2" />
<PackageReference Include="xunit" Version="2.3.0-beta1-build3642" />
<PackageReference Include="xunit.runner.visualstudio" Version="2.3.0-beta1-build1309" />
<PackageReference Include="xunit" Version="2.3.1" />
<PackageReference Include="xunit.runner.visualstudio" Version="2.3.1" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.0.0-preview-20170222-09" />
<!-- <PackageReference Include="Microsoft.NETCore.App" Version="1.0.2" /> -->
</ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ public async Task HttpClient_IncludesContentLengthHeaderOnExpectedHttpVerbs(Http
}
}

private static IEnumerable<object[]> HttpMethods()
public static IEnumerable<object[]> HttpMethods()
{
yield return new[] { HttpMethod.Delete };
yield return new[] { HttpMethod.Post };
Expand Down
3 changes: 1 addition & 2 deletions src/SDKs/Batch/DataPlane/Azure.Batch/AssemblyAttributes.cs
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,9 @@
[assembly: AssemblyDescription("Client library for interacting with the Azure Batch service.")]

[assembly: AssemblyVersion("8.0.0.0")]
[assembly: AssemblyFileVersion("8.1.0.0")]
[assembly: AssemblyFileVersion("8.1.1.0")]
[assembly: AssemblyCompany("Microsoft Corporation")]
[assembly: AssemblyProduct("Microsoft Azure")]
[assembly: AssemblyCopyright("Copyright (c) Microsoft Corporation. All rights reserved.")]
[assembly: CLSCompliant(false)]
[assembly: ComVisible(false)]

Expand Down
2 changes: 1 addition & 1 deletion src/SDKs/Batch/DataPlane/Azure.Batch/Azure.Batch.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<GenerateAssemblyCompanyAttribute>false</GenerateAssemblyCompanyAttribute>
<PackageId>Azure.Batch</PackageId>
Copy link
Copy Markdown
Contributor

@shahabhijeet shahabhijeet Apr 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we publish a second package with the appropriate name (Microsoft.Azure.*) in addition to this package.

Copy link
Copy Markdown
Member Author

@matthchr matthchr Apr 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will discuss this with my team and get back to you.

<Description>This client library provides access to the Microsoft Azure Batch service.</Description>
<VersionPrefix>8.1.0</VersionPrefix>
<VersionPrefix>8.1.1</VersionPrefix>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matthchr add packageReleaseNotes for this release.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shahabhijeet We already have it, it's just in a lower <PropertyGroup>

It says: <PackageReleaseNotes>For detailed release notes, see: https://aka.ms/batch-net-dataplane-changelog</PackageReleaseNotes>

<DefineConstants>$(DefineConstants);CODESIGN</DefineConstants>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<AssemblyName>Microsoft.Azure.Batch</AssemblyName>
Expand Down
3 changes: 2 additions & 1 deletion src/SDKs/Batch/DataPlane/Azure.Batch/Generated/CloudJob.cs
Original file line number Diff line number Diff line change
Expand Up @@ -422,7 +422,8 @@ public DateTime? StateTransitionTime
/// </summary>
/// <remarks>
/// This property is populated only if the <see cref="CloudJob"/> was retrieved with an <see cref="ODATADetailLevel.ExpandClause"/>
/// including the 'stats' attribute; otherwise it is null.
/// including the 'stats' attribute; otherwise it is null. The statistics may not be immediately available. The Batch
/// service performs periodic roll-up of statistics. The typical delay is about 30 minutes.
/// </remarks>
public JobStatistics Statistics
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,8 @@ public DateTime? StateTransitionTime
/// </summary>
/// <remarks>
/// This property is populated only if the <see cref="CloudJobSchedule"/> was retrieved with an <see cref="ODATADetailLevel.ExpandClause"/>
/// including the 'stats' attribute; otherwise it is null.
/// including the 'stats' attribute; otherwise it is null. The statistics may not be immediately available. The Batch
/// service performs periodic roll-up of statistics. The typical delay is about 30 minutes.
/// </remarks>
public JobScheduleStatistics Statistics
{
Expand Down
3 changes: 2 additions & 1 deletion src/SDKs/Batch/DataPlane/Azure.Batch/Generated/CloudPool.cs
Original file line number Diff line number Diff line change
Expand Up @@ -560,7 +560,8 @@ public DateTime? StateTransitionTime
/// </summary>
/// <remarks>
/// This property is populated only if the <see cref="CloudPool"/> was retrieved with an <see cref="ODATADetailLevel.ExpandClause"/>
/// including the 'stats' attribute; otherwise it is null.
/// including the 'stats' attribute; otherwise it is null. The statistics may not be immediately available. The Batch
/// service performs periodic roll-up of statistics. The typical delay is about 30 minutes.
/// </remarks>
public PoolStatistics Statistics
{
Expand Down
13 changes: 12 additions & 1 deletion src/SDKs/Batch/DataPlane/Azure.Batch/Generated/CloudTask.cs
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,15 @@ namespace Microsoft.Azure.Batch
/// <summary>
/// An Azure Batch task. A task is a piece of work that is associated with a job and runs on a compute node.
/// </summary>
/// <remarks>
/// Batch will retry tasks when a recovery operation is triggered on a compute node. Examples of recovery operations
/// include (but are not limited to) when an unhealthy compute node is rebooted or a compute node disappeared due to
/// host failure. Retries due to recovery operations are independent of and are not counted against the <see cref="TaskConstraints.MaxTaskRetryCount"
/// />. Even if the <see cref="TaskConstraints.MaxTaskRetryCount" /> is 0, an internal retry due to a recovery operation
/// may occur. Because of this, all tasks should be idempotent. This means tasks need to tolerate being interrupted and
/// restarted without causing any corruption or duplicate data. The best practice for long running tasks is to use some
/// form of checkpointing.
/// </remarks>
public partial class CloudTask : ITransportObjectProvider<Models.TaskAddParameter>, IInheritedBehaviors, IPropertyMetadata
{
private class PropertyContainer : PropertyCollection
Expand Down Expand Up @@ -285,7 +294,9 @@ public AuthenticationTokenSettings AuthenticationTokenSettings
/// <remarks>
/// The command line does not run under a shell, and therefore cannot take advantage of shell features such as environment
/// variable expansion. If you want to take advantage of such features, you should invoke the shell in the command
/// line, for example using "cmd /c MyCommand" in Windows or "/bin/sh -c MyCommand" in Linux.
/// line, for example using \"cmd /c MyCommand\" in Windows or \"/bin/sh -c MyCommand\" in Linux. If the command
/// line refers to file paths, it should use a relative path (relative to the task working directory), or use the
/// Batch provided environment variables (https://docs.microsoft.com/en-us/azure/batch/batch-compute-node-environment-variables).
/// </remarks>
public string CommandLine
{
Expand Down
17 changes: 14 additions & 3 deletions src/SDKs/Batch/DataPlane/Azure.Batch/Generated/JobManagerTask.cs
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,17 @@ namespace Microsoft.Azure.Batch
using System.Linq;

/// <summary>
/// Represents an Azure Batch JobManager task.
/// Represents an Azure Batch JobManager task.
/// </summary>
/// <remarks>
/// Batch will retry tasks when a recovery operation is triggered on a compute node. Examples of recovery operations
/// include (but are not limited to) when an unhealthy compute node is rebooted or a compute node disappeared due to
/// host failure. Retries due to recovery operations are independent of and are not counted against the <see cref="TaskConstraints.MaxTaskRetryCount"
/// />. Even if the <see cref="TaskConstraints.MaxTaskRetryCount" /> is 0, an internal retry due to a recovery operation
/// may occur. Because of this, all tasks should be idempotent. This means tasks need to tolerate being interrupted and
/// restarted without causing any corruption or duplicate data. The best practice for long running tasks is to use some
/// form of checkpointing.
/// </remarks>
public partial class JobManagerTask : ITransportObjectProvider<Models.JobManagerTask>, IPropertyMetadata
{
private class PropertyContainer : PropertyCollection
Expand Down Expand Up @@ -147,7 +156,7 @@ internal JobManagerTask(Models.JobManagerTask protocolObject)

/// <summary>
/// Gets or sets whether the Job Manager task may run on a low-priority compute node. If omitted, the default is
/// false.
/// true.
/// </summary>
public bool? AllowLowPriorityNode
{
Expand Down Expand Up @@ -190,7 +199,9 @@ public AuthenticationTokenSettings AuthenticationTokenSettings
/// <remarks>
/// The command line does not run under a shell, and therefore cannot take advantage of shell features such as environment
/// variable expansion. If you want to take advantage of such features, you should invoke the shell in the command
/// line, for example using "cmd /c MyCommand" in Windows or "/bin/sh -c MyCommand" in Linux.
/// line, for example using "cmd /c MyCommand" in Windows or "/bin/sh -c MyCommand" in Linux. If the command line
/// refers to file paths, it should use a relative path (relative to the task working directory), or use the Batch
/// provided environment variables (https://docs.microsoft.com/en-us/azure/batch/batch-compute-node-environment-variables).
/// </remarks>
public string CommandLine
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,15 @@ namespace Microsoft.Azure.Batch
/// <summary>
/// A Job Preparation task to run before any tasks of the job on any given compute node.
/// </summary>
/// <remarks>
/// Batch will retry tasks when a recovery operation is triggered on a compute node. Examples of recovery operations
/// include (but are not limited to) when an unhealthy compute node is rebooted or a compute node disappeared due to
/// host failure. Retries due to recovery operations are independent of and are not counted against the <see cref="TaskConstraints.MaxTaskRetryCount"
/// />. Even if the <see cref="TaskConstraints.MaxTaskRetryCount" /> is 0, an internal retry due to a recovery operation
/// may occur. Because of this, all tasks should be idempotent. This means tasks need to tolerate being interrupted and
/// restarted without causing any corruption or duplicate data. The best practice for long running tasks is to use some
/// form of checkpointing.
/// </remarks>
public partial class JobPreparationTask : ITransportObjectProvider<Models.JobPreparationTask>, IPropertyMetadata
{
private class PropertyContainer : PropertyCollection
Expand Down Expand Up @@ -118,7 +127,9 @@ internal JobPreparationTask(Models.JobPreparationTask protocolObject)
/// <remarks>
/// The command line does not run under a shell, and therefore cannot take advantage of shell features such as environment
/// variable expansion. If you want to take advantage of such features, you should invoke the shell in the command
/// line, for example using "cmd /c MyCommand" in Windows or "/bin/sh -c MyCommand" in Linux.
/// line, for example using "cmd /c MyCommand" in Windows or "/bin/sh -c MyCommand" in Linux. If the command line
/// refers to file paths, it should use a relative path (relative to the task working directory), or use the Batch
/// provided environment variables (https://docs.microsoft.com/en-us/azure/batch/batch-compute-node-environment-variables).
/// </remarks>
public string CommandLine
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,9 @@ internal JobReleaseTask(Models.JobReleaseTask protocolObject)
/// <remarks>
/// The command line does not run under a shell, and therefore cannot take advantage of shell features such as environment
/// variable expansion. If you want to take advantage of such features, you should invoke the shell in the command
/// line, for example using "cmd /c MyCommand" in Windows or "/bin/sh -c MyCommand" in Linux.
/// line, for example using "cmd /c MyCommand" in Windows or "/bin/sh -c MyCommand" in Linux. If the command line
/// refers to file paths, it should use a relative path (relative to the task working directory), or use the Batch
/// provided environment variables (https://docs.microsoft.com/en-us/azure/batch/batch-compute-node-environment-variables).
/// </remarks>
public string CommandLine
{
Expand Down
6 changes: 6 additions & 0 deletions src/SDKs/Batch/DataPlane/Azure.Batch/Generated/NodeCounts.cs
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ internal NodeCounts(Models.NodeCounts protocolObject)
{
this.Creating = protocolObject.Creating;
this.Idle = protocolObject.Idle;
this.LeavingPool = protocolObject.LeavingPool;
this.Offline = protocolObject.Offline;
this.Preempted = protocolObject.Preempted;
this.Rebooting = protocolObject.Rebooting;
Expand Down Expand Up @@ -55,6 +56,11 @@ internal NodeCounts(Models.NodeCounts protocolObject)
/// </summary>
public int Idle { get; }

/// <summary>
/// Gets the number of nodes in <see cref="Common.ComputeNodeState.LeavingPool" />.
/// </summary>
public int LeavingPool { get; }

/// <summary>
/// Gets the number of nodes in <see cref="Common.ComputeNodeState.Offline" />.
/// </summary>
Expand Down
13 changes: 12 additions & 1 deletion src/SDKs/Batch/DataPlane/Azure.Batch/Generated/StartTask.cs
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,15 @@ namespace Microsoft.Azure.Batch
/// A task which is run when a compute node joins a pool in the Azure Batch service, or when the compute node is rebooted
/// or reimaged.
/// </summary>
/// <remarks>
/// Batch will retry tasks when a recovery operation is triggered on a compute node. Examples of recovery operations
/// include (but are not limited to) when an unhealthy compute node is rebooted or a compute node disappeared due to
/// host failure. Retries due to recovery operations are independent of and are not counted against the <see cref="TaskConstraints.MaxTaskRetryCount"
/// />. Even if the <see cref="TaskConstraints.MaxTaskRetryCount" /> is 0, an internal retry due to a recovery operation
/// may occur. Because of this, all tasks should be idempotent. This means tasks need to tolerate being interrupted and
/// restarted without causing any corruption or duplicate data. The best practice for long running tasks is to use some
/// form of checkpointing.
/// </remarks>
public partial class StartTask : ITransportObjectProvider<Models.StartTask>, IPropertyMetadata
{
private class PropertyContainer : PropertyCollection
Expand Down Expand Up @@ -107,7 +116,9 @@ internal StartTask(Models.StartTask protocolObject)
/// <remarks>
/// The command line does not run under a shell, and therefore cannot take advantage of shell features such as environment
/// variable expansion. If you want to take advantage of such features, you should invoke the shell in the command
/// line, for example using "cmd /c MyCommand" in Windows or "/bin/sh -c MyCommand" in Linux.
/// line, for example using "cmd /c MyCommand" in Windows or "/bin/sh -c MyCommand" in Linux. If the command line
/// refers to file paths, it should use a relative path (relative to the task working directory), or use the Batch
/// provided environment variables (https://docs.microsoft.com/en-us/azure/batch/batch-compute-node-environment-variables).
/// </remarks>
public string CommandLine
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,14 @@ internal TaskConstraints(Models.TaskConstraints protocolObject)
/// <summary>
/// Gets or sets the maximum number of retries for the task.
/// </summary>
/// <remarks>
/// Note that this value specifically controls the number of retries for the task executable due to a nonzero exit
/// code. The Batch service will try the task once, and may then retry up to this limit. For example, if the maximum
/// retry count is 3, Batch tries the task up to 4 times (one initial try and 3 retries). If the maximum retry count
/// is 0, the Batch service does not retry the task after the first attempt. If the maximum retry count is -1, the
/// Batch service retries the task without limit. Resource files and application packages are only downloaded again
/// if the task is retried on a new compute node.
/// </remarks>
public int? MaxTaskRetryCount
{
get { return this.propertyContainer.MaxTaskRetryCountProperty.Value; }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,9 @@ namespace Microsoft.Azure.Batch
using System.Linq;

/// <summary>
/// The definition of the user identity under which the task is run.
/// The definition of the user identity under which the task is run. On CloudServiceConfiguration pools, this user is
/// logged in with the INTERACTIVE flag. On Windows VirtualMachineConfiguration pools, this user is logged in with the
/// BATCH flag.
/// </summary>
public partial class UserIdentity : ITransportObjectProvider<Models.UserIdentity>, IPropertyMetadata
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,9 @@ public partial interface IJobOperations
/// <remarks>
/// Statistics are aggregated across all jobs that have ever existed in
/// the account, from account creation to the last update time of the
/// statistics.
/// statistics. The statistics may not be immediately available. The
/// Batch service performs periodic roll-up of statistics. The typical
/// delay is about 30 minutes.
/// </remarks>
/// <param name='jobGetAllLifetimeStatisticsOptions'>
/// Additional parameters for the operation
Expand Down Expand Up @@ -245,9 +247,12 @@ public partial interface IJobOperations
/// <remarks>
/// When a Terminate Job request is received, the Batch service sets
/// the job to the terminating state. The Batch service then terminates
/// any active or running tasks associated with the job, and runs any
/// required Job Release tasks. The job then moves into the completed
/// state.
/// any running tasks associated with the job and runs any required job
/// release tasks. Then the job moves into the completed state. If
/// there are any tasks in the job in the active state, they will
/// remain in the active state. Once a job is terminated, new tasks
/// cannot be added and any remaining active tasks will not be
/// scheduled.
/// </remarks>
/// <param name='jobId'>
/// The ID of the job to terminate.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,9 @@ public partial interface IPoolOperations
/// <remarks>
/// Statistics are aggregated across all pools that have ever existed
/// in the account, from account creation to the last update time of
/// the statistics.
/// the statistics. The statistics may not be immediately available.
/// The Batch service performs periodic roll-up of statistics. The
/// typical delay is about 30 minutes.
/// </remarks>
/// <param name='poolGetAllLifetimeStatisticsOptions'>
/// Additional parameters for the operation
Expand Down
Loading