Skip to content

Azure Batch C# SDK version 8.1.1#4270

Merged
shahabhijeet merged 3 commits intoAzure:psSdkJson6from
matthchr:feature/batch-8.1.1
Apr 30, 2018
Merged

Azure Batch C# SDK version 8.1.1#4270
shahabhijeet merged 3 commits intoAzure:psSdkJson6from
matthchr:feature/batch-8.1.1

Conversation

@matthchr
Copy link
Member

@matthchr matthchr commented Apr 26, 2018 •
edited
Loading

Description

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

matthchr added 3 commits April 24, 2018 17:32
@matthchr
Update Batch dataplane SDK to 8.1.1
666eb7d 
  - Fixed a bug where ListNodeCounts didn't correctly return nodes in LeavingPool state.
  - Various documentation updates.
  - Updated changelog.
@matthchr
Update xunit.runner.visualstudio to 2.3.1
bd8aedc 
  - This makes it easier to run tests from VisualStudio since
    we don't have conflicting versions of the runner.
@matthchr
Add support for Batch OM codegenerator class remarks
40a4138 
  - Now supports both remarks and summary comments.
@matthchr
Copy link
Member Author

matthchr commented Apr 26, 2018

The Swagger PR is here: Azure/azure-rest-api-specs#2885

@matthchr
Copy link
Member Author

matthchr commented Apr 26, 2018

Note for reviewers: The "Update Batch dataplane SDK to 8.1.1" commit is the most interesting one. The "Add support for Batch OM codegenerator class remarks" commit adds a lot of files with a small change in each and is quite Batch specific so you might want to skip that one

@dsgouda dsgouda requested a review from shahabhijeet April 27, 2018 17:15
shahabhijeet
shahabhijeet suggested changes Apr 30, 2018
View reviewed changes
src/SDKs/Batch/DataPlane/Azure.Batch/Azure.Batch.csproj
@@ -10,7 +10,7 @@
<GenerateAssemblyCompanyAttribute>false</GenerateAssemblyCompanyAttribute>
<PackageId>Azure.Batch</PackageId>
Copy link
Contributor

@shahabhijeet shahabhijeet Apr 30, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we publish a second package with the appropriate name (Microsoft.Azure.*) in addition to this package.

Copy link
Member Author

@matthchr matthchr Apr 30, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will discuss this with my team and get back to you.

src/SDKs/Batch/DataPlane/Azure.Batch/Azure.Batch.csproj
<PackageId>Azure.Batch</PackageId>
<Description>This client library provides access to the Microsoft Azure Batch service.</Description>
<VersionPrefix>8.1.0</VersionPrefix>
<VersionPrefix>8.1.1</VersionPrefix>
Copy link
Contributor

@shahabhijeet shahabhijeet Apr 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matthchr add packageReleaseNotes for this release.

Copy link
Member Author

@matthchr matthchr Apr 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shahabhijeet We already have it, it's just in a lower <PropertyGroup>

It says: <PackageReleaseNotes>For detailed release notes, see: https://aka.ms/batch-net-dataplane-changelog</PackageReleaseNotes>

@shahabhijeet shahabhijeet merged commit 6ec3722 into Azure:psSdkJson6 Apr 30, 2018
@matthchr matthchr deleted the feature/batch-8.1.1 branch April 30, 2018 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@shahabhijeet shahabhijeet shahabhijeet approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@shahabhijeet shahabhijeet

Labels

Do Not Merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@matthchr @shahabhijeet