Skip to content

SignalR #4241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dsgouda merged 6 commits into from
May 4, 2018
Merged

SignalR #4241

dsgouda merged 6 commits into from
May 4, 2018

Conversation

@sergey-shandar
Copy link
Contributor

@sergey-shandar sergey-shandar commented Apr 17, 2018 •
edited
Loading

Description

SignalR

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

dsgouda
dsgouda suggested changes Apr 17, 2018
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from a few minor comments

src/SDKs/SignalR/AzSdk.RP.props Outdated
<Project ToolsVersion="15.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<!--This file and it's contents are updated at build time moving or editing might result in build failure. Take due deligence while editing this file-->
<PropertyGroup>
<AzureApiTag />
Copy link
Contributor

@dsgouda dsgouda Apr 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add 2018-03-01-preview as the AzureApiTag here

Copy link
Contributor Author

@sergey-shandar sergey-shandar Apr 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I manually updated the file.

src/SDKs/SignalR/Management.SignalR/Microsoft.Azure.Management.SignalR.csproj
<!-- Please do not move/edit code below this line -->

<PropertyGroup>
<PackageId>Microsoft.Azure.Management.SignalR</PackageId>
Copy link
Contributor

@dsgouda dsgouda Apr 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Please verify this is how the RP wants their packages to be named

Copy link
Contributor Author

@sergey-shandar sergey-shandar Apr 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

src/SDKs/SignalR/Management.SignalR/Generated/Models/Resource.cs
@@ -0,0 +1,72 @@
// <auto-generated>
// Copyright (c) Microsoft Corporation. All rights reserved.
Copy link
Contributor

@dsgouda dsgouda Apr 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not have been generated, did we add the x-ms-azure-resource flag in the spec

shahabhijeet
shahabhijeet suggested changes May 2, 2018
View reviewed changes
src/SDKs/SignalR/AzSdk.RP.props Outdated
<Project ToolsVersion="15.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<!--This file and it's contents are updated at build time moving or editing might result in build failure. Take due deligence while editing this file-->
<PropertyGroup>
<AzureApiTag>2018-03-01-preview</AzureApiTags>
Copy link
Contributor

@shahabhijeet shahabhijeet May 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sergey-shandar the start/end tags do not match.
Delete this file and simply build from command line
msbuild build.proj /t:Build /p:Scope=SDKs\SignalR
it will create the file and update the meta data.

shahabhijeet
shahabhijeet approved these changes May 2, 2018
View reviewed changes
Copy link
Contributor

@shahabhijeet shahabhijeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the CI passes this can be merged

@dsgouda dsgouda merged commit 12d05b8 into Azure:psSdkJson6 May 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@dsgouda dsgouda dsgouda approved these changes

@shahabhijeet shahabhijeet shahabhijeet approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dsgouda dsgouda

@shahabhijeet shahabhijeet

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sergey-shandar @dsgouda @shahabhijeet