Skip to content

Content Moderator- Add SSN parameter to Screen Text API response#4195

Merged
dsgouda merged 2 commits intoAzure:psSdkJson6from
v-sodsou:SSNchange
Apr 9, 2018
Merged

Content Moderator- Add SSN parameter to Screen Text API response#4195
dsgouda merged 2 commits intoAzure:psSdkJson6from
v-sodsou:SSNchange

Conversation

@v-sodsou
Copy link
Contributor

@v-sodsou v-sodsou commented Apr 6, 2018

Description

Link to Spec PR - Azure/azure-rest-api-specs#2815

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@v-sodsou v-sodsou changed the title Add SSN parameter to Screen Text API response Content Moderator- Add SSN parameter to Screen Text API response Apr 6, 2018
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a generate.ps1 file similar to this and regenerate the code.
Please run msbuild build.proj /t:build /p:Scope=SDKs\CognitiveServices\dataplane\Vision\ContenModerator This should generate a .props file, please commit this file

// [assembly: AssemblyVersion("1.0.*")]
[assembly: AssemblyVersion("0.10.0.0")]
[assembly: AssemblyFileVersion("0.10.0.0")]
[assembly: AssemblyVersion("0.11.0.0")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not update the AssemblyVersion

@dsgouda
Copy link
Contributor

dsgouda commented Apr 6, 2018

Please link the related REST spec PR

@dsgouda dsgouda self-assigned this Apr 6, 2018
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda dsgouda merged commit f04e5fa into Azure:psSdkJson6 Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants