-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Add SSN parameter to Content Moderator Screen text API #2815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-nodeThe initial PR has been merged into your service PR: |
Automation for azure-libraries-for-javaThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-goA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
|
@jhendrixMSFT Thanks |
| "format": "binary", | ||
| "type": "string" | ||
| "type": "object", | ||
| "format": "file" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to be sure it's clear to you, that's a breaking change. Before, it was taking a string in memory, now it's taking a file descriptor.
If you expect this to be possibly massive file as input, it makes sense, but still breaking and samples will have to be updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will update the sample. I had to change this as autorest generated sdk files for string type text content serializes the string content . For example “profanity term” string gets serialized as ""profanity term""
Which causes the profanity term index(position) response from sdk to alter by +1 position(ex: index for this profanity text should be 0 but sdk returns 1).
So I was suggested this change to avoid manual change of sdk files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that you're talking about C# only :).
If you feel there is a bug in the C# SDK generator, please open an issue to fix that instead of changing the Swagger. If you feel that input as file descriptor is better anyway, that's fine as well. Please, it's important to separate a possible bug that impacts C# only, to a global design question about the input type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I discussed this with sdk code generator team and apparently if the type is "string", the assumption is that it needs to be deserialized. And they don't have a way to say "not to deserialize that" . So its not a bug from their end. Regarding other languages, all languages support stream so shouldn't be a problem.I got this verified with their team.
lmazuel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but please confirm explicitly the breaking change is expected.
| } | ||
|
|
||
| }, | ||
| "SSN": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no examples, so I can just trust you than the actual JSON received is as described :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will update the example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirm this change is expected.
|
@annatisch FYI |
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger