Skip to content

[Azure Search] Add several indexer features to SDK#4179

Merged
brjohnstmsft merged 4 commits intoAzure:search-4x-preview-vs17from
chaosrealm:parameters-for-http-encode-functions
Mar 30, 2018
Merged

[Azure Search] Add several indexer features to SDK#4179
brjohnstmsft merged 4 commits intoAzure:search-4x-preview-vs17from
chaosrealm:parameters-for-http-encode-functions

Conversation

@chaosrealm
Copy link
Copy Markdown

@chaosrealm chaosrealm commented Mar 30, 2018

Description

Add several missing indexer features to get to parity with REST API:

  • Warnings
  • Parameters to Base64Encode and Base64Decode functions
  • Text parsing mode
  • Removed some obsolete features

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

Copy link
Copy Markdown
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please link the related rest spec repo PR
Please create a generate.ps1 file similar to this and regenerate the code here
Looks good other than that

@chaosrealm
Copy link
Copy Markdown
Author

Link to the specs PR: Azure/azure-rest-api-specs#2759
The code was regenerated already.

@brjohnstmsft
Copy link
Copy Markdown
Member

@dsgouda Please note that the target of this PR is a branch owned by the Azure Search team for which we have merge permissions. This is for our preview SDK. Customers are waiting for a hotfix in this branch, which I'd like to publish to NuGet today. I'll make the changes to the generate scripts when we merge these latest changes back to the psSdkJson6 branch.

@dsgouda
Copy link
Copy Markdown
Contributor

dsgouda commented Mar 30, 2018

@brjohnstmsft acknowledged, approving at my end.

@brjohnstmsft brjohnstmsft merged commit 1e37be3 into Azure:search-4x-preview-vs17 Mar 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants