Skip to content

[Azure Search] Add indexer warnings to latest preview API spec#2759

Merged
dsgouda merged 1 commit intoAzure:masterfrom
chaosrealm:indexer-warnings
Mar 28, 2018
Merged

[Azure Search] Add indexer warnings to latest preview API spec#2759
dsgouda merged 1 commit intoAzure:masterfrom
chaosrealm:indexer-warnings

Conversation

@chaosrealm
Copy link
Copy Markdown
Contributor

@chaosrealm chaosrealm commented Mar 27, 2018

Adding indexer warnings to IndexerExecutionInfo class to bring the SDK to parity with the REST API surface

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Mar 27, 2018

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Mar 27, 2018

Automation for azure-libraries-for-java

Nothing to generate for azure-libraries-for-java

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Mar 27, 2018

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Mar 27, 2018

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

@brjohnstmsft
Copy link
Copy Markdown
Member

LGTM

@dsgouda
Copy link
Copy Markdown
Contributor

dsgouda commented Mar 28, 2018

@chaosrealm please update the examples in order to fix issues reported here

Copy link
Copy Markdown
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants