adding dns name label support for azure container instance .net sdk#4049
Merged
shahabhijeet merged 4 commits intoAzure:psSdkJson6from Feb 7, 2018
Merged
adding dns name label support for azure container instance .net sdk#4049shahabhijeet merged 4 commits intoAzure:psSdkJson6from
shahabhijeet merged 4 commits intoAzure:psSdkJson6from
Conversation
Contributor
Author
|
@shahabhijeet , could you take a look of this change? It is very simple. I am just adding new property (dns name label) for the container instance. |
shahabhijeet
reviewed
Feb 6, 2018
Contributor
shahabhijeet
left a comment
shahabhijeet
left a comment
There was a problem hiding this comment.
Missing link to your swagger spec PR
Missing meta data file that get's updated when you use generate.cmd to generate
| <PropertyGroup> | ||
| <Description>Microsoft Azure Container Instance Management Library</Description> | ||
| <Version>1.0.1-preview</Version> | ||
| <Version>1.0.2-preview</Version> |
Contributor
There was a problem hiding this comment.
Missing < PackageReleaseNotes >. Add release notes as to what is being fixed/added to this release.
Contributor
Author
There was a problem hiding this comment.
@shahabhijeet , fixed. Please take a look.
shahabhijeet
approved these changes
Feb 7, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With this change, user can now specify a dns name label for the container they create in ACI using Azure .Net SDK.
The only semantics changes are in ipaddress.cs (to include the new property) and tests. Changes in other files are mostly format changes from AutoRest
Link to the PR for rest api spec:
Azure/azure-rest-api-specs#2309
A simple bug fix (casing) to the spec:
Azure/azure-rest-api-specs#2410
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.