Skip to content

fixing the casing of the new Dns Name Label property#2410

Merged
lmazuel merged 1 commit intoAzure:masterfrom
xizha162:master
Feb 3, 2018
Merged

fixing the casing of the new Dns Name Label property#2410
lmazuel merged 1 commit intoAzure:masterfrom
xizha162:master

Conversation

@xizha162
Copy link
Copy Markdown
Contributor

@xizha162 xizha162 commented Feb 2, 2018 •
edited by azuresdkci
Loading

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Feb 2, 2018

Did a commit to Azure/azure-sdk-for-python:
Azure/azure-sdk-for-python@839c15b

@AutorestCI AutorestCI mentioned this pull request Feb 2, 2018
Merged
@xizha162
Copy link
Copy Markdown
Contributor Author

xizha162 commented Feb 2, 2018

@yolo3301 , please take a look. This should solve the errors in the python tests.

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Feb 2, 2018

Did a commit to Azure/azure-sdk-for-go:
Azure/azure-sdk-for-go@fd103f5

@AutorestCI AutorestCI mentioned this pull request Feb 2, 2018
Closed
yolocs
yolocs approved these changes Feb 2, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@yolocs yolocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@azuresdkciprbot
Copy link
Copy Markdown

azuresdkciprbot commented Feb 2, 2018

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/containerinstance/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

lmazuel
lmazuel approved these changes Feb 3, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@lmazuel lmazuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lmazuel lmazuel merged commit 976e003 into Azure:master Feb 3, 2018
@xizha162 xizha162 mentioned this pull request Feb 6, 2018
Merged
9 tasks
mccleanp pushed a commit that referenced this pull request Mar 23, 2022
@sureleo @shul-msft
[This RP hasn't been launched] Remove instanceEndpoint from SQL MIAA (#…
9ce7ce1 
…2410)

* Remove instanceEndpoint from SQL MIAA

* Fix example

Co-authored-by: Shuo Li <shul@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lmazuel lmazuel lmazuel approved these changes

+1 more reviewer

@yolocs yolocs yolocs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lmazuel lmazuel

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@xizha162 @AutorestCI @azuresdkciprbot @lmazuel @yolocs