Skip to content

Adding LogAnalytics API.#4035

Merged
shahabhijeet merged 1 commit intoAzure:psSdkJson6from
hyonholee:loganalytics
Feb 6, 2018
Merged

Adding LogAnalytics API.#4035
shahabhijeet merged 1 commit intoAzure:psSdkJson6from
hyonholee:loganalytics

Conversation

@hyonholee
Copy link
Contributor

@hyonholee hyonholee commented Feb 2, 2018

Azure/azure-rest-api-specs#2383

Description


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hyonholee please use package reference and not reference

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason you are not using the package reference?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we do not support .NET 46, this piece of code will never be executed.
Any reason for adding .NET 46 moniker?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your test is never built against .NET 46, so this is essentially dead code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shahabhijeet Yes. This is a dead code, but in our repo, we build tests using NET46 because moving to netcore is not done in our repo. Since we copy test codes from our internal repo to github, we need to change it every time. That is why I added this part.

@huangpf
Copy link
Contributor

huangpf commented Feb 6, 2018

@shahabhijeet MGMT SDKs in other languages than C# do not nee to submit their SDK code and test changes. Can you help explain why is that? Or can you also waive C# for this part. Thanks.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason you are not using the package reference?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants