Adding LogAnalytics to Compute spec by waynekuo · Pull Request #2383 · Azure/azure-rest-api-specs

waynekuo · 2018-01-31T02:55:04Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

…ion fields.

…casing.

# Conflicts: # arm-compute/2016-04-30-preview/swagger/compute.json

…sing VM sizes.

AutorestCI · 2018-01-31T03:03:20Z

Did a commit to Azure/azure-sdk-for-python:
Azure/azure-sdk-for-python@f440fbc

AutorestCI · 2018-01-31T03:04:41Z

Did a commit to Azure/azure-sdk-for-go:
Azure/azure-sdk-for-go@5727437

huangpf · 2018-01-31T20:03:36Z

@AutorestCI
Can you do a commit to Azure/azure-sdk-for-net?

AutorestCI · 2018-02-01T00:55:32Z

Did a commit to Azure/azure-sdk-for-python:
Azure/azure-sdk-for-python@713bf84

AutorestCI · 2018-02-01T01:10:39Z

This commit was treated and no generation was made for Azure/azure-sdk-for-go

…esponse.

AutorestCI · 2018-02-01T01:56:05Z

Did a commit to Azure/azure-sdk-for-python:
Azure/azure-sdk-for-python@4d053f6

AutorestCI · 2018-02-01T01:58:14Z

This commit was treated and no generation was made for Azure/azure-sdk-for-go

jianghaolu

You need to reference the examples from the Swagger spec using x-ms-examples.

AutorestCI · 2018-02-01T19:06:41Z

This commit was treated and no generation was made for Azure/azure-sdk-for-go

waynekuo · 2018-02-01T19:37:48Z

Added references to example files.

AutorestCI · 2018-02-01T19:46:46Z

This commit was treated and no generation was made for Azure/azure-sdk-for-go

AutorestCI · 2018-02-01T20:07:40Z

This commit was treated and no generation was made for Azure/azure-sdk-for-python

AutorestCI · 2018-02-01T20:15:57Z

This commit was treated and no generation was made for Azure/azure-sdk-for-python

jianghaolu · 2018-02-01T23:17:35Z

...urce-manager/Microsoft.Compute/stable/2017-12-01/examples/LogAnalyticsThrottledRequests.json

+  },
+  "responses": {
+    "200": {
+      "body": {


In the Swagger, 200 doesn't return a response body.

Updated the Swagger file now. 200 should return a response body. Missed the copy from our internal repo.

jianghaolu · 2018-02-01T23:35:26Z

...-manager/Microsoft.Compute/stable/2017-12-01/examples/LogAnalyticsRequestRateByInterval.json

+    }
+  },
+  "responses": {
+    "200": {


In the Swagger, 200 doesn't return a response body.

jianghaolu · 2018-02-01T23:36:16Z

...urce-manager/Microsoft.Compute/stable/2017-12-01/examples/LogAnalyticsThrottledRequests.json

+    "subscriptionId": "{subscription-id}",
+    "api-version": "2017-12-01",
+    "parameters": {
+      "location": "westus",


"location" is a top-level parameter.

jianghaolu · 2018-02-01T23:36:20Z

...-manager/Microsoft.Compute/stable/2017-12-01/examples/LogAnalyticsRequestRateByInterval.json

+    "subscriptionId": "{subscription-id}",
+    "api-version": "2017-12-01",
+    "parameters": {
+      "location": "westus",


"location" is a top-level parameter.

AutorestCI · 2018-02-01T23:50:43Z

This commit was treated and no generation was made for Azure/azure-sdk-for-python

AutorestCI · 2018-02-01T23:52:50Z

Did a commit to Azure/azure-sdk-for-go:
Azure/azure-sdk-for-go@b89e10d

jianghaolu · 2018-02-02T00:44:56Z

...-manager/Microsoft.Compute/stable/2017-12-01/examples/LogAnalyticsRequestRateByInterval.json

+    "location": "westus",
+    "api-version": "2017-12-01",
+    "parameters": {
+      "properties": {


Please extract everything out of both "RequestRateByIntervalInput" and "properties". The "parameters" section should contain the parameters in this format:

"<parameter-name>": <actual payload>

In this case, the actual payload is

{ "intervalLength": "FiveMins", "blobContainerSasUri": "https://somesasuri", "fromTime": "2018-01-21T01:54:06.862601Z", "toTime": "2018-01-23T01:54:06.862601Z", "groupByResourceName": true }

You can see another example in compute here: https://github.com/Azure/azure-rest-api-specs/blob/master/specification/compute/resource-manager/Microsoft.Compute/stable/2017-12-01/examples/CreateAScaleSetFromACustomImage.json#L8

Same for the other example.

jianghaolu · 2018-02-02T00:45:16Z

...-manager/Microsoft.Compute/stable/2017-12-01/examples/LogAnalyticsRequestRateByInterval.json

+      "body": ""
+    },
+    "202": {
+      "body": {


202 doesn't have a body either :) Same for the other example.

I reacted too quickly to your comment. Actually 202 doesn't have a response, but the long running async will give a response on 200. I just somehow missed that update from our internal repo.

azuresdkciprbot · 2018-02-02T02:12:01Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/compute/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 39
After the PR: Warning(s): 0 Error(s): 39

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-02-02T02:14:54Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/compute/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 39
After the PR: Warning(s): 0 Error(s): 39

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

AutorestCI · 2018-02-02T02:24:25Z

This commit was treated and no generation was made for Azure/azure-sdk-for-go

AutorestCI · 2018-02-02T02:38:33Z

This commit was treated and no generation was made for Azure/azure-sdk-for-go

AutorestCI · 2018-02-02T02:42:33Z

Did a commit to Azure/azure-sdk-for-python:
Azure/azure-sdk-for-python@80a076c

AutorestCI · 2018-02-02T03:24:33Z

This commit was treated and no generation was made for Azure/azure-sdk-for-python

unknown and others added 6 commits December 6, 2016 13:41

Updating Compute 2016-3-30 swagger spec for casing issues in descript…

26ea57c

…ion fields.

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

7c10e07

- Fixing 'CreateOption' in Compute swagger to ARM recommended Pascal …

8e249cc

…casing.

Updating description for LinuxConfiguration.

6500f65

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

7e386db

# Conflicts: # arm-compute/2016-04-30-preview/swagger/compute.json

Adding LogAnalytics to comptue spec and also including previously mis…

8eb897f

…sing VM sizes.

AutorestCI mentioned this pull request Jan 31, 2018

[Compute] Adding LogAnalytics to Compute spec Azure/azure-sdk-for-python#1863

Merged

AutorestCI mentioned this pull request Jan 31, 2018

Automatic PR of restapi_auto_waynekuo_master into dev Azure/azure-sdk-for-go#1022

Closed

azuresdkci assigned jianghaolu Jan 31, 2018

Adding response type models in swagger and example files.

03fbec7

Updating LogAnalyticsOperationResult to inherit from OperationStatusR…

2ff7912

…esponse.

Fixing typo in example file.

64fd1a4

jianghaolu suggested changes Feb 1, 2018

View reviewed changes

Adding references to example files.

c13dab7

jianghaolu suggested changes Feb 1, 2018

View reviewed changes

Updating example files.

b322d91

jianghaolu suggested changes Feb 2, 2018

View reviewed changes

waynekuo added 2 commits February 1, 2018 18:05

Updating example files and correcting 200 reponse body.

66438a9

Updating example files.

5f2d932

jianghaolu approved these changes Feb 2, 2018

View reviewed changes

jianghaolu merged commit 0609009 into Azure:master Feb 2, 2018

hyonholee mentioned this pull request Feb 2, 2018

Adding LogAnalytics API. Azure/azure-sdk-for-net#4035

Merged

9 tasks

Conversation

waynekuo commented Jan 31, 2018 • edited by azuresdkci Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR information

Quality of Swagger

Uh oh!

AutorestCI commented Jan 31, 2018

Uh oh!

AutorestCI commented Jan 31, 2018

Uh oh!

huangpf commented Jan 31, 2018

Uh oh!

AutorestCI commented Feb 1, 2018

Uh oh!

AutorestCI commented Feb 1, 2018

Uh oh!

AutorestCI commented Feb 1, 2018

Uh oh!

AutorestCI commented Feb 1, 2018

Uh oh!

jianghaolu left a comment

Choose a reason for hiding this comment

Uh oh!

AutorestCI commented Feb 1, 2018

Uh oh!

waynekuo commented Feb 1, 2018

Uh oh!

AutorestCI commented Feb 1, 2018

Uh oh!

AutorestCI commented Feb 1, 2018

Uh oh!

AutorestCI commented Feb 1, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AutorestCI commented Feb 1, 2018

Uh oh!

AutorestCI commented Feb 1, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

azuresdkciprbot commented Feb 2, 2018

Uh oh!

azuresdkciprbot commented Feb 2, 2018

Uh oh!

AutorestCI commented Feb 2, 2018

Uh oh!

AutorestCI commented Feb 2, 2018

Uh oh!

AutorestCI commented Feb 2, 2018

Uh oh!

AutorestCI commented Feb 2, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

waynekuo commented Jan 31, 2018 •

edited by azuresdkci

Loading