Skip to content

Onboard API version 2017-08-01#4014

Merged
shahabhijeet merged 9 commits intoAzure:psSdkJson6from
shihying:shihying-sdk0801
Feb 2, 2018
Merged

Onboard API version 2017-08-01#4014
shahabhijeet merged 9 commits intoAzure:psSdkJson6from
shihying:shihying-sdk0801

Conversation

@shihying
Copy link
Contributor

@shihying shihying commented Jan 24, 2018

Description

Onboard API version 0801, regenerate ASAzure SDK based on a 0801 version swagger spec.

PR:
Azure/azure-rest-api-specs#2306
Merged Commit:
Azure/azure-rest-api-specs@cb9c18b

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@shihying shihying changed the title Shihying sdk0801 Onboard API version 2017-08-01 Jan 24, 2018
Copy link
Contributor

@shahabhijeet shahabhijeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do the following in below order

  1. Generate SDK using generate.cmd (this add required meta data file)
  2. Once SDK generated, build your project as below
    msbuild build.proj /t:build /p:Scope=SDKs\AnalysisServices
    this will add second meta data file that is required.
    Update the PR

<Version>2.0.3</Version>
<AssemblyName>Microsoft.Azure.Management.Analysis</AssemblyName>
<PackageId>ManagementAnalysis;Analysis</PackageId>
<PackageId>Microsoft.Azure.Management.Analysis</PackageId>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add package release notes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@shihying
Copy link
Contributor Author

@shahabhijeet

Thanks for reminder, have used generate.cmd and rebuild to generate metadata file
Also updated release note.

@shihying
Copy link
Contributor Author

@shahabhijeet Please take a look on latest iteration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants