Skip to content

Add a stable api version 2017-08-01#2306

Merged
jhendrixMSFT merged 2 commits intoAzure:masterfrom
shihying:shihying-bump0801stable
Jan 22, 2018
Merged

Add a stable api version 2017-08-01#2306
jhendrixMSFT merged 2 commits intoAzure:masterfrom
shihying:shihying-bump0801stable

Conversation

@shihying
Copy link
Contributor

@shihying shihying commented Jan 22, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/analysisservices/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@jhendrixMSFT
Copy link
Member

@shihying I assume this is the GA version of 2017-08-01-beta yes? Were there any changes between beta and GA? Also do we need to keep the beta version still?

@jhendrixMSFT
Copy link
Member

Also you'll need to update the README file will this version.

@shihying
Copy link
Contributor Author

@jhendrixMSFT YES this is just a GA version of 2017-08-01, and there is no change between beta and GA
beta is just a testing version for our limited customer.

We want to keep all versions for now including beta.

Thanks for your reminder! I have updated README.md and used autorest to generate SDK

@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/analysisservices/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@jhendrixMSFT jhendrixMSFT merged commit cb9c18b into Azure:master Jan 22, 2018
@AutorestCI
Copy link

Was unable to find SDK Azure/azure-sdk-for-python PR for this closed PR.

@AutorestCI
Copy link

No modification for AutorestCI/azure-sdk-for-python

@AutorestCI
Copy link

@AutorestCI
Copy link

No modification for AutorestCI/azure-sdk-for-python

mccleanp pushed a commit that referenced this pull request Mar 23, 2022
* Updated readme.md with new languages

* Added new readme file

added java, nodejs, cli and schema readme.md files

* Updated Swagger with Agreement terms api

added agreement terms API

* added example file for AgreementTerms

added GetAgreementTerms and SignAgreementTerms

* Updated the email regex

updated the email regex

* Updated with Terms API

added marketplace terms api

* update and rename set marketplace terms

* update and rename Get marketplace terms list

* Update Marketplace Set Example

* update confluent.json

* Updated email regex

* addressed comments

addressed the comments changed the API to PUT

* Updated Swagger Spec to address comments

* Updated Example response

* Updated Agreements List example

* lint fix

* rename

* lint fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants