Skip to content

Add delegation support for RA calls#3872

Merged
shahabhijeet merged 10 commits intoAzure:psSdkJson6from
darshanhs90:psSdkJson6
Nov 29, 2017
Merged

Add delegation support for RA calls#3872
shahabhijeet merged 10 commits intoAzure:psSdkJson6from
darshanhs90:psSdkJson6

Conversation

@darshanhs90
Copy link
Contributor

@darshanhs90 darshanhs90 commented Nov 18, 2017 •
edited
Loading

Linked to the following swagger specs pr
Azure/azure-rest-api-specs#2031
Azure/azure-rest-api-specs#2043

Description

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@darshanhs90
Copy link
Contributor Author

darshanhs90 commented Nov 23, 2017

@shahabhijeet API specs PR has been merged

@darshanhs90 darshanhs90 mentioned this pull request Nov 23, 2017
Merged
13 tasks
shahabhijeet
shahabhijeet suggested changes Nov 27, 2017
View reviewed changes
Copy link
Contributor

@shahabhijeet shahabhijeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@darshanhs90 regenerate your SDK from the merged spec.
When you do that, you will get an additional .txt file as part of your PR.

src/SDKs/Authorization/Authorization.Tests/Authorization.Tests.csproj Outdated

<ItemGroup>
<PackageReference Include="Microsoft.Azure.Management.Authorization" Version="2.5.0-preview" />
<!--<PackageReference Include="Microsoft.Azure.Management.Authorization" Version="2.5.0-preview" />-->
Copy link
Contributor

@shahabhijeet shahabhijeet Nov 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@darshanhs90 remove commented code.
Also start using latest version of ResourceManager to record all your tests. The latest version is 1.6.0 for ResourceManager nuget package.

Copy link
Contributor Author

@darshanhs90 darshanhs90 Nov 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved it

In reply to: 153349537 [](ancestors = 153349537)

@darshanhs90
Copy link
Contributor Author

darshanhs90 commented Nov 28, 2017

@shahabhijeet Made all the changes as per the comments and rerecorded the tests

@darshanhs90
Copy link
Contributor Author

darshanhs90 commented Nov 29, 2017

@shahabhijeet Fixed merge conflict issue and updated the version

shahabhijeet
shahabhijeet suggested changes Nov 29, 2017
View reviewed changes
src/SDKs/Authorization/Management.Authorization/Microsoft.Azure.Management.Authorization.csproj
<Description>Provides capabilities to query Microsoft Azure Management Authorization.</Description>
<AssemblyTitle>Authorization Library for Microsoft Azure Management Authorization</AssemblyTitle>
<Version>2.5.0-preview</Version>
<Version>2.6.0-preview</Version>
Copy link
Contributor

@shahabhijeet shahabhijeet Nov 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@darshanhs90 please add packageRelease notes, it's left blank.

Copy link
Contributor Author

@darshanhs90 darshanhs90 Nov 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shahabhijeet Added package release notes back

@shahabhijeet shahabhijeet merged commit 0d9d0b8 into Azure:psSdkJson6 Nov 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@shahabhijeet shahabhijeet shahabhijeet approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@darshanhs90 @shahabhijeet