Fix regression caused by previous merge

[darshanhs90]

Related to #2031

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

• The title of the PR is clear and informative.
• There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
• Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
• If applicable, the PR references the bug/issue that it fixes.
• Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

• I have read the contribution guidelines.
• My spec meets the review criteria:
  • The spec conforms to the Swagger 2.0 specification.
  • The spec follows the guidelines described in the Swagger checklist document.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.

[mcardosos]

From what we talked offline, this should stay as type

[darshanhs90]

since there are two fields with name "type" in the response that is sent by the service.
we cant name this as type,because we would leave out the property with value(for example) type which corresponds to "CUSTOM Role"

[mcardosos]

From what we talked offline, this should be renamed to roleName

[darshanhs90]

since there are two fields with name "type" in the response that is sent by the service.
we cant name this as rolename,because it wouldnt match the property "type" and would miss out having the value like custom role/builtin role

[mcardosos]

Okok, there was some confusion on my side.
The property name should be the very same that is returned by the service. In this case, if you want to still get the benefits from x-ms-client-flatten, there is another extension that can be used to override the property name in the SDK code without changing serialization. Look into x-ms-client-name

---

In reply to: 152688623 [](ancestors = 152688623)

[mcardosos]

Okok, there was some confusion on my side.
The property name should be the very same that is returned by the service. In this case, if you want to still get the benefits from x-ms-client-flatten, there is another extension that can be used to override the property name in the SDK code without changing serialization. Look into x-ms-client-name

[azuresdkciprbot]

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/authorization/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 1
After the PR: Warning(s): 0 Error(s): 1

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

[azuresdkciprbot]

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/authorization/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 1
After the PR: Warning(s): 0 Error(s): 1

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

[AutorestCI]

No modification for AutorestCI/azure-sdk-for-node

[AutorestCI]

Azure/azure-sdk-for-ruby#1145

[AutorestCI]

Azure/azure-sdk-for-python#1645