[App Config] Snapshot API updates#38391
Merged
ShivangiReja merged 4 commits intoAzure:mainfrom Aug 28, 2023
Merged
Conversation
ShivangiReja
requested review from
KrzysztofCwalina,
jsquire,
pallavit and
tg-msft
as code owners
github-actions
bot
added
the
App Configuration
jsquire
approved these changes
Aug 28, 2023
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes the following changes:
Moves the protocol methods from the custom
ConfigurationClientto the generatedConfigurationClient. This action addresses the resolved issue of method ambiguity in the code generation. (Reference: Update protocol methods using overload if there is ambiguity #36351)Since all generated methods include the
afterparameter, which remains unused within the public API, theafterparameter is being removed from theGetSnapshotsmethod.Renames the
selectparameter tofieldsin the methodsGetSnapshotandGetSnapshots.