Update protocol methods using overload if there is ambiguity#36351
Merged
pshao25 merged 25 commits intoAzure:mainfrom Jul 7, 2023
Merged
Update protocol methods using overload if there is ambiguity#36351pshao25 merged 25 commits intoAzure:mainfrom
pshao25 merged 25 commits intoAzure:mainfrom
Conversation
github-actions
bot
added
App Configuration
Collaborator
Author
|
API change check APIView has identified API level changes in this PR and created following API reviews. Azure.Template |
pshao25
changed the title
pshao25
requested review from
JialinXin,
KrzysztofCwalina,
amnguye,
annelo-msft,
jaschrep-msft,
seanmcc-msft,
tg-msft,
vicancy and
wonner
as code owners
Member
|
LGTM |
chunyu3
approved these changes
May 23, 2023
Member
|
It is allowed to update the RequestContext required on existing SDKs which is not GAed. |
m-nash
reviewed
May 23, 2023
sdk/agrifood/Azure.Verticals.AgriFood.Farming/src/Generated/Attachments.cs
Show resolved
Hide resolved
heaths
approved these changes
May 25, 2023
…/github.com/azure-sdk/azure-sdk-for-net into auto-update-autorest-3.0.0-alpha.20230517.5
…o auto-update-autorest-3.0.0-alpha.20230517.5
…o auto-update-autorest-3.0.0-alpha.20230517.5
…o auto-update-autorest-3.0.0-alpha.20230517.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the change we are going to apply after Azure/autorest.csharp#3412
For GAed libraries we add the config:
keep-non-overloadable-protocol-signature: trueto keep the signature unchanged.For non-GAed libraries we let the protocol methods to change and need to update the calls to the protocol method.