Move generator shared source files to Azure.Core shared source

[annelo-msft]

Fixes #32006

Azure/autorest.csharp#3674 and #38305 show proof of concept that once Azure.Core shared source in the autorest.charp repo is updated by the script, we expect build and test to succeed.

[azure-sdk]

API change check

API changes are not detected in this pull request.

[christothes]

Should we log an issue to close some of the test coverage gaps here?

[annelo-msft]

Should we log an issue to close some of the test coverage gaps here?

@christothes, which test coverage gaps?

[christothes]

Should we log an issue to close some of the test coverage gaps here?

@christothes, which test coverage gaps?

There may not be any in practice, I was just comparing classes with test classes and there appear to be some missing tests.

[annelo-msft]

I was just comparing classes with test classes and there appear to be some missing tests.

Cool, good call out, then. I'll file that issue - do you have a list handy, or is it primarily just "there are methods without tests validating their functionality?"

[christothes]

I was just comparing classes with test classes and there appear to be some missing tests.

Cool, good call out, then. I'll file that issue - do you have a list handy, or is it primarily just "there are methods without tests validating their functionality?"

The latter

[annelo-msft]

#38304

[annelo-msft]

I think this is ready to go now, but will wait for @m-nash for final approval to make sure I'm not missing something in all the back-and-forth steps across repos.

Next steps are:

• Merge this PR
• For this PR: Move shared source from Generator.Shared to Azure.Core.Shared autorest.csharp#3674
  • Update it to get Azure.Core shared source from main
  • Get approval and merge
• For the PR generated from updating Move shared source from Generator.Shared to Azure.Core.Shared autorest.csharp#3674, we will add the new changes from this PR: Autorest Regen Preview to 3.0.0-alpha.20230821.4 by Anne Loomis Thompson from refs/pull/3674/head #38305
  • Get approval and merge