Conversation
|
Thank you for your contribution @subhra231! We will review the pull request and get back to you soon. |
jsquire
left a comment
There was a problem hiding this comment.
I realize this is still in draft, but I left some feedback around tweaks that we'll need to make to integrate into the Azure SDK repository and some conversations that we'll need to have with the architects around naming.
| @@ -0,0 +1,199 @@ | |||
| # top-most EditorConfig file | |||
There was a problem hiding this comment.
Please remove; we'll want to conform to the standards from the repository root .editorconfig
There was a problem hiding this comment.
Makes sense. Removed it.
| @@ -0,0 +1,81 @@ | |||
| Microsoft Visual Studio Solution File, Format Version 12.00 | |||
There was a problem hiding this comment.
Unless we're planning on strictly adopting the API patterns in the Azure SDK Guidelines, these packages cannot use the Azure.* prefix. We'll need to move them over to Microsoft.Azure.*.
If we are planning to adhere to the SDK guidelines, we'll need to start a conversation with the archboard - particularly @KrzysztofCwalina and @tg-msft - around the namespace. CoreWCF is not currently an approved service area.
| @@ -0,0 +1,9 @@ | |||
| Using the CoreWCF Postman Samples Collection.json within Postman | |||
There was a problem hiding this comment.
We'll need to update this to follow the README conventions described in the guidelines.
| @@ -0,0 +1,8 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <configuration> | |||
| <packageSources> | |||
There was a problem hiding this comment.
This cannot be included when the PR is merged. The Azure SDK repository only permits package references from NuGet or the Azure SDK development feed.
There was a problem hiding this comment.
This was actually the remnant from our previous code. We no longer need the config file. so removed it
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Azure.Storage.Queues" /> | ||
| <PackageReference Include="NuGet.Commands" VersionOverride="6.5.0" /> |
There was a problem hiding this comment.
These dependencies will need to be approved by the architects and added to the central package versions. We generally do not want to include local VersionOverrides unless there's a temporary exceptional case.
| using Azure.Storage.Queues; | ||
| using CoreWCF.Channels; | ||
|
|
||
| namespace Azure.Storage.CoreWCF.Channels |
There was a problem hiding this comment.
We'll need to review namesapces here. I do not believe that we'd want these to start with Azure.Storage.
//cc: @KrzysztofCwalina, @tg-msft
| namespace Azure.Storage.CoreWCF.Channels | ||
| { | ||
| /// <summary> | ||
| /// The class storing binding information |
There was a problem hiding this comment.
The doc comments for public members will be rendered in MS Docs. I believe that we'll need to spend some time tuning these as customer-facing documentation.
| /// </summary> | ||
| public static string GetEndpointUrl(string accountName, string queueName) | ||
| { | ||
| return $"net.aqs://{accountName}.queue.core.windows.net/{queueName}"; |
There was a problem hiding this comment.
I do not believe this works across Azure clouds and with Azure stack, as written.
| <PackageReference Include="Microsoft.AspNetCore" /> | ||
| <PackageReference Include="Microsoft.Extensions.Configuration.UserSecrets" VersionOverride="3.1.13" /> | ||
| <PackageReference Include="Microsoft.NET.Test.Sdk" /> | ||
| <PackageReference Include="xunit" /> |
There was a problem hiding this comment.
The Azure SDK repository is standardized on NUnit, outside of some exceptions for deprecated legacy packages. We'll want to convert over from xunit.
| private readonly ITestOutputHelper _output = null; | ||
| public const string QueueName = "AzureQueue"; | ||
|
|
||
| [Fact(Skip = "Need AzureQueue")] |
There was a problem hiding this comment.
We'll want to convert this over to the Azure SDK test infrastructure for live test support.
|
Can we please shift the source path to |
|
//fyi: @KrzysztofCwalina, @tg-msft, @schaabs |
Sure, Have updated the path to sdk/wcf |
|
Hi @subhra231. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
|
Hi @subhra231. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing |
* Added new Typespec version for STG101 (Azure#38546) * new typespec version * Added generated_blob * updated default tag in readme * Added examples directory * Cross-Tenant support for Principal Bound Delegation Sas 101 (TypeSpec) (Azure#38626) * added DelegatedUserTid * Add generated_blob.json * re-commented @azure-tools/typespec-csharp * updated formatting * Added SKUs (Azure#38658) * Merged main (Azure#38661) * Spelling baseline and corrections for .github folder (Azure#38545) * Baseline for .github folder * Narrow exceptions for some spellings * Format * spell check tests/fixtures * [.github/shared] type-check tests (Azure#38532) - Enable TypeScript type checking of test files - Address all type errors - Preparing to enable eslint type-checked ruleset - In future PR, will enable type-checking of tests in `.github/workflows` * Migrate conditional flatten to flattenProperty (Azure#38541) * npm update (Azure#38548) * Durabletask: Revert client rename to meet .NET naming conventions (Azure#38552) * Revert "[DurableTask] Rename SDK classes for 1.0.0 release (Azure#38143)" This reverts commit 485b347. * DurableTask client: add new class name --------- Co-authored-by: Bernd Verst <beverst@microsoft.com> * desktopvirtualization 2025-08-01-preview & 2025-09-01-preview (Azure#36798) desktopvirtualization 2025-08-01-preview & 2025-09-01-preview Co-authored-by: Rui Guo <guorui@microsoft.com> Co-authored-by: Liwei Ying <liweiying@microsoft.com> * Update the csharp codegen settings for mysql (Azure#38566) * Update the DurableTask configuration to support the new MPG (Azure#38568) * java, mgmt, elasticsan config (Azure#38569) * java, mgmt, acr, config readme (Azure#38570) * Swagger changes to Support Jira V2 in ADF (Azure#38430) * Update Dataset.json for Jira dataset properties Updated the Dataset.json to reference JiraTableDatasetTypeProperties and added properties for Jira dataset. * Add JiraDatasetTypeProperties to Dataset.json Added Jira dataset properties with descriptions for tableName, table, and schema. * Change dataset reference from Generic to Jira type * Update Jira dataset descriptions for V2 support * Update Jira dataset descriptions for V2 support --------- Co-authored-by: Jingshu918 <138486531+Jingshu918@users.noreply.github.com> * Using new management plain generator for service dependency map (Azure#38567) * update tspconfig.yaml. * replace suffix "Request" With "Content" in model names. * update client.tsp * update client.tsp * fix format issue. * mgmt, java, monitor, directive to avoid enum of duplicated name (Azure#38572) * Update readme.md (Azure#38565) Co-authored-by: Weidong Xu <weidxu@microsoft.com> * add python config (Azure#38576) * Update productType and language descriptions for clarity in models and OpenAPI specifications (Azure#38559) * Review request for Microsoft.ContainerService/aks to add version preview/2025-09-02-preview (Azure#38472) * Adds base for updating Microsoft.ContainerService/aks from version preview/2025-08-02-preview to version preview/2025-09-02-preview * Updates readme * Updates API version in new specs and examples * add alb addon to managed cluster ingress profile (Azure#38022) * Update managed namespace preview api based on GA api (Azure#38036) * add default domain to aks preview 2025-09-02 (Azure#38037) * feat: Support nftables mode in kube-proxy (Azure#38030) * feat: Support nftables mode in kube-proxy * allow nftables word * asdf * asdf * asdf * remove outdated maintenance config examples (Azure#38057) Co-authored-by: juanbe <juanbe@microsoft.com> * Added new kata naming convention to preview API. (Azure#38067) --------- Co-authored-by: Sneha Chhabria <59101963+snehachhabria@users.noreply.github.com> Co-authored-by: Yiran Li <109549277+purpleran7@users.noreply.github.com> Co-authored-by: Oliver King <olivermerkleyking@gmail.com> Co-authored-by: Jack Ma <jack4it@hotmail.com> Co-authored-by: Juan Diego Bencardino <jdbencardinop@unal.edu.co> Co-authored-by: juanbe <juanbe@microsoft.com> Co-authored-by: Martin Heberling <martin.heberling.dalies@gmail.com> * added older preview versions (Azure#38397) * added older preview swagger * added back 20241115preview and 20250515preview in typespec * updated readme * add older preview swagger * added 20241115preview and 20250515preview in typespec for Conv inference * updated readme * added older preview swaggers for conv authoring * add older preview in typespec * update readme * fix typespec validation * updated readme * removed 20241115preview from analyzetext * remove from analyzetext readme * removed 20241115preview from analyze conversations * remove from analyzeconversation readme * removed 20241115preview from analyzeconversationauthoring * removed from analyzeconversationauthoring readme * Sync eng/common directory with azure-sdk-tools for PR 12531 (Azure#38583) * prompt * this * line * update bens suggestions * update * remove try to find pkg path logic * Update eng/common/instructions/azsdk-tools/check-package-validation.instructions.md Co-authored-by: Ben Broderick Phillips <ben@benbp.net> * path * updates * list numbering incorrect * linting --------- Co-authored-by: l0lawrence <llawrence@microsoft.com> Co-authored-by: Ben Broderick Phillips <ben@benbp.net> * Update Microsoft365 naming to Channels (Azure#38517) * Migrate newrelic to TypeSpec (Azure#36442) * generated * update * update * update * update * update * delete * update * update * remove x-cadl-generated * update * delete consumes * update * rename folder * remove legacyoperation * update tspconfig * format * update summary and description * update * add namepattern * fix java package name * service-dir for java * Update tspconfig.yaml * update * add config for python * rename op name for python * sync go directive * update package name for js sdk * remove rename config for python * update service-dir for js sdk * fix * Update output directory and module for New Relic * update client name for js * Add createOrUpdate client for MonitoredSubscriptions * update --------- Co-authored-by: melina5656 <140602263+melina5656@users.noreply.github.com> Co-authored-by: Weidong Xu <weidxu@microsoft.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn> Co-authored-by: Jiao Di (MSFT) <80496810+v-jiaodi@users.noreply.github.com> Co-authored-by: Pan Shao <97225342+pshao25@users.noreply.github.com> * service bus config (Azure#38578) * Redis Enterprise API Version `2025-08-01-preview` with both AMR Migration and Scheduled Update features (Azure#38286) * Add maintenance config fields to ARM spec * Move versions from private repo to public for Microsoft.Datadog (Azure#38009) * Base commit * Add new api versions * Fix SDK validation * Unify EdgeActions with CDN 2025-09-01-preview and migrate to TypeSpec (Azure#38054) * Add EdgeActions 2025-09-01-preview baseline from 2024-07-22-preview Copy EdgeActions API specification from 2024-07-22-preview to new EdgeActions directory structure as baseline for 2025-09-01-preview. * Migrate EdgeActions to TypeSpec with API changes for 2025-09-01-preview - Convert EdgeActions from JSON swagger to TypeSpec - Add TypeSpec configuration for all SDK languages (Python, Java, Go, TypeScript, C#) - Configure separate Azure.ResourceManager.EdgeActions package for .NET SDK - Add @clientName decorator for EdgeActionAttachmentResponse -> EdgeActionAttachmentResult (C# naming convention) - Add file-scoped suppression for ProvisioningStateMustBeReadOnly - Add new operations: SwapDefault, DeployVersionCode, GetVersionCode - Update all examples to 2025-09-01-preview - Generate OpenAPI via TypeSpec compiler with automatic x-ms-examples * fix java sdk validation * fix(edgeactions): address PR review comments for 2025-09-01-preview - Add x-ms-client-flatten and x-ms-mutability to properties field on EdgeAction, EdgeActionVersion, and EdgeActionExecutionFilter resource models for backwards compatibility with 2024-07-22-preview baseline - Change EdgeActionAttachmentResponse.edgeActionId from readOnly to x-ms-mutability [read, update, create] to match baseline behavior - Replace 'ARM' with 'Azure' in resource identifier descriptions (AttachedResourceId and EdgeActionVersionId) - Consolidate multiple PostResponseCodes suppressions into single entry with array of where clauses in readme.md - Add OpenAPI extension decorators using @@extension augments in TypeSpec with appropriate suppressions for no-openapi warnings * style(edgeactions): apply tsp format to TypeSpec files - Reformat @@extension calls to multi-line style for better readability - Reorder #suppress directive placement per formatter rules * remove unnecessary ProvisioningStateMustBeReadOnly suppression All provisioningState properties are already correctly marked as readOnly in the generated OpenAPI spec. The suppression is not needed as the spec complies with ARM validation rules. * Revert "remove unnecessary ProvisioningStateMustBeReadOnly suppression" This reverts commit a5988e2e2c8188e0836b5d366bb19469535ca772. * extend ResourceProvisioningState for standard ARM compliance Change ProvisioningState to extend ResourceProvisioningState which provides the three required states (Succeeded, Failed, Canceled) with standard ARM descriptions, and add custom states (Provisioning, Upgrading) specific to edge actions lifecycle. * remove ProvisioningStateMustBeReadOnly suppression Suppression no longer needed after extending ResourceProvisioningState which properly handles ARM validation requirements. * add use-read-only-status-schema to resolve ProvisioningStateMustBeReadOnly validation Enable use-read-only-status-schema: true in tspconfig.yaml to work around known limitation in azure-openapi-validator and oav with \ siblings. This adds readOnly: true directly to status schema definitions, resolving ProvisioningStateMustBeReadOnly validation errors. References: - Azure/azure-openapi-validator#637 - Azure/oav#848 --------- Co-authored-by: Danny Tundwe (from Dev Box) <dannytundwe@microsoft.com> * Merge tag for ACR Go release (Azure#38594) * Merge tag for ACR Go release * Update input file path for container registry tasks * fix * update * Add documentation for Defender for Containers resource level (Azure#35905) * Add documentation for Defender for Containers resource level * remove operation status * prettier * remove tags with multiple versions * revert * new line * revert --------- Co-authored-by: ygorshomov <ygorshomov@microsoft.com> * [CQA] Correct typo (Azure#38579) * correct typo * change getImportStatus getExportStatus getDeployStatus getDeleteStatus getUpdateQnasStatus getUpdateSourcesStatus to internal --------- Co-authored-by: Qi Yin <v-qiyin1@microsoft.com> * Waves API (Azure#37394) * Changes for public preview * Adding refresh API * Adding further types for drApplicanceInventoryId * [.github] type-check tests (Azure#38591) * Add contrainerregistry directive (Azure#38619) * add directive * add directive * add directive * add directive * add directive * mgmt, java, monitor, add a tag in readme.java.md for SDK configure (Azure#38616) * remove the csharp config since this library is still generating from swagger (Azure#38599) * Keyvault.Management TypeSpec, fix secrets put (Azure#38620) * fix secret * regen * Merging and 2024-02-15-preview and 2024-06-15-preview api to main (Azure#38359) Merging and 2024-02-15-preview and 2024-06-15-preview api to main (Azure#38359) * Sync eng/common directory with azure-sdk-tools for PR 12476 (Azure#38607) * add tool instructions prompt * minor * prompt revision * prompt revision and fallback to core requirements * rename langs to languages + revise prompt * edit prompt and make checks concurrent * fix prompt * add venvPath argument * minor prompt and log edit --------- Co-authored-by: jennypng <63012604+JennyPng@users.noreply.github.com> * Remove arm-resource-flattening and migrate to explicity flattenProperty (Azure#38581) * omit constructors (Azure#38588) * Update with the configuration to run go generate after tsp compile. (Azure#38609) There are some post-generation steps that run after tsp generation, to create the system events enum. Adding in this switch ensures we generate the same client in all of our systems. This shouldn't change anything about generation, but it will mean the automated APIView diffs will work properly. * Fix tag in dns-resolver new version for swagger generations (Azure#38635) * remove HDInsight On Aks api specs (Azure#38593) Co-authored-by: Yukun Li (Beyondsoft) <v-yukunli@microsoft.com> * Updated the description for the boundingBox property of the address object. (Azure#38554) * Release Microsoft.Network API Version 2025-03-01 (Azure#38556) * Copy files from stable/2025-01-01 Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec. * Update version to stable/2025-03-01 Updated the API version from stable/2025-01-01 to stable/2025-03-01. * Added tag for 2025-03-01 in readme file * Copy readme.md suppressions and directives from previous stable version * Application Gateway Entra JWT Validation Feature Support (Azure#38335) * Application Gateway Entra JWT Validation Feature Support * fixing doe style issues --------- Co-authored-by: Hemant Imudianda <heimudia@microsoft.com> * Application Gateway MTLS Passthrough Feature Support (Azure#38337) Co-authored-by: Hemant Imudianda <heimudia@microsoft.com> Co-authored-by: Prajjwal Kamboj <kamboj.prjwl@gmail.com> * Remove NonSensitivity for DDoS ruleset (Azure#38246) * Remove NonSensitivity * make change in the right API folder * add suppression --------- Co-authored-by: Prajjwal Kamboj <kamboj.prjwl@gmail.com> Co-authored-by: Judy Liu <v-liujudy@microsoft.com> * Adding recordType field to 2025-03-01 version (Azure#38361) * Adding recordType field to 2025-03-01 version * Changed description of RecordType --------- Co-authored-by: Riddhi Nilawar <rinilawar@microsoft.com> * Add new DdosCustomPolicy properties + update examples (Azure#38272) * Add DCP properties + update examples to 2024-07-01 to 2025-03-01 * Remove unecessary FIP from examples * Remove < 2025-03-01 API version changes + Resolve PR feedback * Remove unecessary type * Fix PR comments * Attempt --------- Co-authored-by: Prajjwal Kamboj <kamboj.prjwl@gmail.com> * Updating Examples Files For ErGwScale Get / Update (Azure#38419) * update examples * updated the jsons --------- Co-authored-by: Prajjwal Kamboj <kamboj.prjwl@gmail.com> * IpVersionType property for Private Endpoint API (Azure#38497) * Addedipconfig type * Fix indentation * Addressing comments * Added example --------- Co-authored-by: Piyush Mishra <piyushmishra@microsoft.com> Co-authored-by: Prajjwal Kamboj <kamboj.prjwl@gmail.com> * IP Preservation API Support (Azure#38358) * IP Preservation API Support --------- Co-authored-by: Prajjwal Kamboj <kamboj.prjwl@gmail.com> --------- Co-authored-by: Prajjwal Kamboj <pkamboj@microsoft.com> Co-authored-by: Hemant Imudianda <hemant.imudianda@apcera.com> Co-authored-by: Hemant Imudianda <heimudia@microsoft.com> Co-authored-by: baoqihuang0326 <119557638+baoqihuang0326@users.noreply.github.com> Co-authored-by: Judy Liu <v-liujudy@microsoft.com> Co-authored-by: riddhinilawar <62386378+riddhinilawar@users.noreply.github.com> Co-authored-by: Riddhi Nilawar <rinilawar@microsoft.com> Co-authored-by: Jennifer Wong <156020508+jwong-MS@users.noreply.github.com> Co-authored-by: aneeshakella-microsoft <109654329+aneeshakella-microsoft@users.noreply.github.com> Co-authored-by: Piyush Mishra <95299755+bzpiyush@users.noreply.github.com> Co-authored-by: Piyush Mishra <piyushmishra@microsoft.com> Co-authored-by: pribansa <134259460+pribansa@users.noreply.github.com> * Add optional boolean to capabilityhost object and rename agentDeployments (Azure#38374) * Add optional boolean to capabilityhost object * Rename applications/deployments to applications/agentDeployments. * Update naming enablePublicHostedCode -> enablePublicHostingEnvironment. * Update suppression to fix path. --------- Co-authored-by: Jeremy Kramer <jkramerdesigns@hotmail.com> * LintDiff: Ensure that default tag is scanned when there is a new tag in the 'after' state (Azure#38611) * LintDiff: Ensure that default tag is scanned when there is a new tag in the 'after' state * Review feedback: break, eliminate empty set handling in favor of empty tag value * Add ability to skip onboarding legacy moniker to Update-DocsMsPackages.ps1 (Azure#38639) Co-authored-by: Daniel Jurek <djurek@microsoft.com> * fix param order (Azure#38657) Co-authored-by: catalinaperalta <caperal@microsoft.com> * Revert "LintDiff: Ensure that default tag is scanned when there is a new tag …" (Azure#38660) This reverts commit acdf013. * Fix EdgeActions 2025-09-01-preview examples: remove invalid provisioning state and SKU values (Azure#38655) * Fix EdgeActions 2025-09-01-preview examples: remove invalid provisioning state and SKU values - Changed provisioningState from 'Accepted' to 'Succeeded' (valid enum value) - Changed SKU name from 'Basic' to 'Standard' in all examples - Affected files: 8 example JSON files in EdgeActions preview API * Fix EdgeActions examples in second directory: remove invalid provisioning state and SKU values - Changed provisioningState from 'Accepted' to 'Succeeded' (valid enum value) - Changed SKU name from 'Basic' to 'Standard' in all examples - Affected files: 6 example JSON files in specification/cdn/resource-manager/Microsoft.Cdn/EdgeActions/examples/2025-09-01-preview/ --------- Co-authored-by: Danny Tundwe (from Dev Box) <dannytundwe@microsoft.com> --------- Co-authored-by: Daniel Jurek <djurek@microsoft.com> Co-authored-by: Mike Harder <mharder@microsoft.com> Co-authored-by: Timothee Guerin <timothee.guerin@outlook.com> Co-authored-by: Bernd Verst <github@bernd.dev> Co-authored-by: Bernd Verst <beverst@microsoft.com> Co-authored-by: Rui Guo <48600426+ruiguoamz@users.noreply.github.com> Co-authored-by: Rui Guo <guorui@microsoft.com> Co-authored-by: Liwei Ying <liweiying@microsoft.com> Co-authored-by: Arthur Ma <mars.arthur@263.net> Co-authored-by: Weidong Xu <weidxu@microsoft.com> Co-authored-by: Sudhir Reddy Emmadi <reddysudhir12@gmail.com> Co-authored-by: Jingshu918 <138486531+Jingshu918@users.noreply.github.com> Co-authored-by: haiyuan_zhang <haiyuan.zhang1982@gmail.com> Co-authored-by: ChenxiJiang333 <119990644+ChenxiJiang333@users.noreply.github.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> Co-authored-by: nirmochiach <mochiachnir@microsoft.com> Co-authored-by: FumingZhang <81607949+FumingZhang@users.noreply.github.com> Co-authored-by: Sneha Chhabria <59101963+snehachhabria@users.noreply.github.com> Co-authored-by: Yiran Li <109549277+purpleran7@users.noreply.github.com> Co-authored-by: Oliver King <olivermerkleyking@gmail.com> Co-authored-by: Jack Ma <jack4it@hotmail.com> Co-authored-by: Juan Diego Bencardino <jdbencardinop@unal.edu.co> Co-authored-by: juanbe <juanbe@microsoft.com> Co-authored-by: Martin Heberling <martin.heberling.dalies@gmail.com> Co-authored-by: amber-Chen-86 <v-amberchen@microsoft.com> Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Co-authored-by: l0lawrence <llawrence@microsoft.com> Co-authored-by: Ben Broderick Phillips <ben@benbp.net> Co-authored-by: fmabroukmsft <134638798+fmabroukmsft@users.noreply.github.com> Co-authored-by: mcgallan <88413158+mcgallan@users.noreply.github.com> Co-authored-by: melina5656 <140602263+melina5656@users.noreply.github.com> Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn> Co-authored-by: Jiao Di (MSFT) <80496810+v-jiaodi@users.noreply.github.com> Co-authored-by: Pan Shao <97225342+pshao25@users.noreply.github.com> Co-authored-by: Xiaofei Cao <92354331+XiaofeiCao@users.noreply.github.com> Co-authored-by: Jim Du <102357939+jim-du@users.noreply.github.com> Co-authored-by: vikotha <81368129+vikotha@users.noreply.github.com> Co-authored-by: tundwed <55289657+tundwed@users.noreply.github.com> Co-authored-by: Danny Tundwe (from Dev Box) <dannytundwe@microsoft.com> Co-authored-by: yossigorshomov <yossigor@gmail.com> Co-authored-by: ygorshomov <ygorshomov@microsoft.com> Co-authored-by: Amichelangelo <37525416+Amichelangelo@users.noreply.github.com> Co-authored-by: Qi Yin <v-qiyin1@microsoft.com> Co-authored-by: sorabhtandon <84002800+sorabhtandon@users.noreply.github.com> Co-authored-by: Judy Liu <v-liujudy@microsoft.com> Co-authored-by: Dapeng Zhang <dapzhang@microsoft.com> Co-authored-by: nnellikunnu <112621306+nnellikunnu@users.noreply.github.com> Co-authored-by: jennypng <63012604+JennyPng@users.noreply.github.com> Co-authored-by: Grace Wilcox <43627800+gracewilcox@users.noreply.github.com> Co-authored-by: Richard Park <51494936+richardpark-msft@users.noreply.github.com> Co-authored-by: jamesvoongms <104241521+jamesvoongms@users.noreply.github.com> Co-authored-by: yk <83654272+2258093686@users.noreply.github.com> Co-authored-by: Yukun Li (Beyondsoft) <v-yukunli@microsoft.com> Co-authored-by: steve munk <33468793+stevemunk@users.noreply.github.com> Co-authored-by: Prajjwal Kamboj <kamboj.prjwl@gmail.com> Co-authored-by: Prajjwal Kamboj <pkamboj@microsoft.com> Co-authored-by: Hemant Imudianda <hemant.imudianda@apcera.com> Co-authored-by: Hemant Imudianda <heimudia@microsoft.com> Co-authored-by: baoqihuang0326 <119557638+baoqihuang0326@users.noreply.github.com> Co-authored-by: riddhinilawar <62386378+riddhinilawar@users.noreply.github.com> Co-authored-by: Riddhi Nilawar <rinilawar@microsoft.com> Co-authored-by: Jennifer Wong <156020508+jwong-MS@users.noreply.github.com> Co-authored-by: aneeshakella-microsoft <109654329+aneeshakella-microsoft@users.noreply.github.com> Co-authored-by: Piyush Mishra <95299755+bzpiyush@users.noreply.github.com> Co-authored-by: Piyush Mishra <piyushmishra@microsoft.com> Co-authored-by: pribansa <134259460+pribansa@users.noreply.github.com> Co-authored-by: Jeremy Kramer <jkramerdesigns@hotmail.com> Co-authored-by: catalinaperalta <9859037+catalinaperalta@users.noreply.github.com> Co-authored-by: catalinaperalta <caperal@microsoft.com> * Added SourceEncryptionKey (Azure#38662) * Added AccessTierIfModifiedSinceParameter & AccessTierIfUnmodifiedSinceParameter (Azure#38665) * tsp compile * clean install + re-compile --------- Co-authored-by: Nick Liu <nicliu@microsoft.com> Co-authored-by: Daniel Jurek <djurek@microsoft.com> Co-authored-by: Mike Harder <mharder@microsoft.com> Co-authored-by: Timothee Guerin <timothee.guerin@outlook.com> Co-authored-by: Bernd Verst <github@bernd.dev> Co-authored-by: Bernd Verst <beverst@microsoft.com> Co-authored-by: Rui Guo <48600426+ruiguoamz@users.noreply.github.com> Co-authored-by: Rui Guo <guorui@microsoft.com> Co-authored-by: Liwei Ying <liweiying@microsoft.com> Co-authored-by: Arthur Ma <mars.arthur@263.net> Co-authored-by: Weidong Xu <weidxu@microsoft.com> Co-authored-by: Sudhir Reddy Emmadi <reddysudhir12@gmail.com> Co-authored-by: Jingshu918 <138486531+Jingshu918@users.noreply.github.com> Co-authored-by: haiyuan_zhang <haiyuan.zhang1982@gmail.com> Co-authored-by: ChenxiJiang333 <119990644+ChenxiJiang333@users.noreply.github.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> Co-authored-by: nirmochiach <mochiachnir@microsoft.com> Co-authored-by: FumingZhang <81607949+FumingZhang@users.noreply.github.com> Co-authored-by: Sneha Chhabria <59101963+snehachhabria@users.noreply.github.com> Co-authored-by: Yiran Li <109549277+purpleran7@users.noreply.github.com> Co-authored-by: Oliver King <olivermerkleyking@gmail.com> Co-authored-by: Jack Ma <jack4it@hotmail.com> Co-authored-by: Juan Diego Bencardino <jdbencardinop@unal.edu.co> Co-authored-by: juanbe <juanbe@microsoft.com> Co-authored-by: Martin Heberling <martin.heberling.dalies@gmail.com> Co-authored-by: amber-Chen-86 <v-amberchen@microsoft.com> Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Co-authored-by: l0lawrence <llawrence@microsoft.com> Co-authored-by: Ben Broderick Phillips <ben@benbp.net> Co-authored-by: fmabroukmsft <134638798+fmabroukmsft@users.noreply.github.com> Co-authored-by: mcgallan <88413158+mcgallan@users.noreply.github.com> Co-authored-by: melina5656 <140602263+melina5656@users.noreply.github.com> Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn> Co-authored-by: Jiao Di (MSFT) <80496810+v-jiaodi@users.noreply.github.com> Co-authored-by: Pan Shao <97225342+pshao25@users.noreply.github.com> Co-authored-by: Xiaofei Cao <92354331+XiaofeiCao@users.noreply.github.com> Co-authored-by: Jim Du <102357939+jim-du@users.noreply.github.com> Co-authored-by: vikotha <81368129+vikotha@users.noreply.github.com> Co-authored-by: tundwed <55289657+tundwed@users.noreply.github.com> Co-authored-by: Danny Tundwe (from Dev Box) <dannytundwe@microsoft.com> Co-authored-by: yossigorshomov <yossigor@gmail.com> Co-authored-by: ygorshomov <ygorshomov@microsoft.com> Co-authored-by: Amichelangelo <37525416+Amichelangelo@users.noreply.github.com> Co-authored-by: Qi Yin <v-qiyin1@microsoft.com> Co-authored-by: sorabhtandon <84002800+sorabhtandon@users.noreply.github.com> Co-authored-by: Judy Liu <v-liujudy@microsoft.com> Co-authored-by: Dapeng Zhang <dapzhang@microsoft.com> Co-authored-by: nnellikunnu <112621306+nnellikunnu@users.noreply.github.com> Co-authored-by: jennypng <63012604+JennyPng@users.noreply.github.com> Co-authored-by: Grace Wilcox <43627800+gracewilcox@users.noreply.github.com> Co-authored-by: Richard Park <51494936+richardpark-msft@users.noreply.github.com> Co-authored-by: jamesvoongms <104241521+jamesvoongms@users.noreply.github.com> Co-authored-by: yk <83654272+2258093686@users.noreply.github.com> Co-authored-by: Yukun Li (Beyondsoft) <v-yukunli@microsoft.com> Co-authored-by: steve munk <33468793+stevemunk@users.noreply.github.com> Co-authored-by: Prajjwal Kamboj <kamboj.prjwl@gmail.com> Co-authored-by: Prajjwal Kamboj <pkamboj@microsoft.com> Co-authored-by: Hemant Imudianda <hemant.imudianda@apcera.com> Co-authored-by: Hemant Imudianda <heimudia@microsoft.com> Co-authored-by: baoqihuang0326 <119557638+baoqihuang0326@users.noreply.github.com> Co-authored-by: riddhinilawar <62386378+riddhinilawar@users.noreply.github.com> Co-authored-by: Riddhi Nilawar <rinilawar@microsoft.com> Co-authored-by: Jennifer Wong <156020508+jwong-MS@users.noreply.github.com> Co-authored-by: aneeshakella-microsoft <109654329+aneeshakella-microsoft@users.noreply.github.com> Co-authored-by: Piyush Mishra <95299755+bzpiyush@users.noreply.github.com> Co-authored-by: Piyush Mishra <piyushmishra@microsoft.com> Co-authored-by: pribansa <134259460+pribansa@users.noreply.github.com> Co-authored-by: Jeremy Kramer <jkramerdesigns@hotmail.com> Co-authored-by: catalinaperalta <9859037+catalinaperalta@users.noreply.github.com> Co-authored-by: catalinaperalta <caperal@microsoft.com>
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.