Skip to content

Update PostLedgerEntryOperation retry logic #38015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christothes merged 7 commits into from
Aug 16, 2023
Merged

Update PostLedgerEntryOperation retry logic #38015

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2e30dd0
Update PostLedgerEntryOperation retry logic
PallabPaul Aug 3, 2023
60668b1
Update Changelog
PallabPaul Aug 3, 2023
d3def66
Update PostLedgerEntryOperation
PallabPaul Aug 3, 2023
96afbe6
Add custom response classifer
PallabPaul Aug 14, 2023
f13d7d4
update changelong
PallabPaul Aug 14, 2023
b1db0b5
update changelog
PallabPaul Aug 14, 2023
0742c01
address comments
PallabPaul Aug 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion sdk/confidentialledger/Azure.Security.ConfidentialLedger/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
# Release History

## 1.2.0-beta.1 (Unreleased)
## 1.2.0 (2023-08-03)

### Bugs Fixed

- Service calls that result in a `HttpStatusCode.NotFound` status will now be retried by default. This is to handle scenarios where there is an unexpected loss of session stickiness when the connected node changes and transactions have not been fully replicated.

## 1.2.0-beta.1 (2022-11-09)

### Features Added

Expand Down
2 changes: 1 addition & 1 deletion sdk/confidentialledger/Azure.Security.ConfidentialLedger/assets.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
"AssetsRepo": "Azure/azure-sdk-assets",
"AssetsRepoPrefixPath": "net",
"TagPrefix": "net/confidentialledger/Azure.Security.ConfidentialLedger",
"Tag": "net/confidentialledger/Azure.Security.ConfidentialLedger_48488df791"
"Tag": "net/confidentialledger/Azure.Security.ConfidentialLedger_5657482b45"
}
2 changes: 1 addition & 1 deletion ...tialledger/Azure.Security.ConfidentialLedger/src/Azure.Security.ConfidentialLedger.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<PropertyGroup>
<Description>Client SDK for the Azure Confidential Ledger service</Description>
<AssemblyTitle>Azure Confidential Ledger</AssemblyTitle>
<Version>1.2.0-beta.1</Version>
<Version>1.2.0</Version>
<!--The ApiCompatVersion is managed automatically and should not generally be modified manually.-->
<ApiCompatVersion>1.1.0</ApiCompatVersion>
<PackageTags>Azure ConfidentialLedger</PackageTags>
Expand Down
10 changes: 9 additions & 1 deletion sdk/confidentialledger/Azure.Security.ConfidentialLedger/src/ConfidentialLedgerClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,11 +78,19 @@ internal ConfidentialLedgerClient(Uri ledgerEndpoint, TokenCredential credential
Array.Empty<HttpPipelinePolicy>() :
new HttpPipelinePolicy[] { new BearerTokenAuthenticationPolicy(_tokenCredential, AuthorizationScopes) },
transportOptions,
new ResponseClassifier());
new ConfidentialLedgerResponseClassifier());
Comment thread
PallabPaul marked this conversation as resolved.
_ledgerEndpoint = ledgerEndpoint;
_apiVersion = actualOptions.Version;
}

internal class ConfidentialLedgerResponseClassifier : ResponseClassifier
{
public override bool IsRetriableResponse(HttpMessage message)
{
return base.IsRetriableResponse(message) || message.Response.Status == 404;
}
}

/// <summary> Posts a new entry to the ledger. A collection id may optionally be specified. </summary>
/// <remarks>
/// Below is the JSON schema for the request and response payloads.
Expand Down