Update PostLedgerEntryOperation retry logic#38015
Merged
Merged
Conversation
Collaborator
|
API change check API changes are not detected in this pull request. |
lynshi
approved these changes
Aug 4, 2023
tg-msft
reviewed
Aug 8, 2023
JoshLove-msft
approved these changes
Aug 14, 2023
christothes
reviewed
Aug 14, 2023
christothes
approved these changes
Aug 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributing to the Azure SDK
Fixes a bug for PostLedgerEntryOperation in both sync and async clients when using waitUntil.Complete. Azure Confidential Ledger generally has client IP-based stickiness so that users observe session consistency. Occasionally this affinity is lost unexpectedly, which can lead to errors when waiting for a commit (write is made to Node A but the read is on Node B, which doesn't know about the write yet). This can be disruptive, so we introduce a small change to retry some
HttpStatusCode.NotFounderrors for all scenarios.Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.