Skip to content

[ClientRuntime] Added PATCH as a valid method when Created status is returned on LRO #3601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ScottHolden wants to merge 1 commit into from
Closed

[ClientRuntime] Added PATCH as a valid method when Created status is returned on LRO #3601

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/SdkCommon/ClientRuntime.Azure/ClientRuntime.Azure/AzureClientExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,7 @@ private static bool CheckResponseStatusCodeFailed<TBody, THeader>(
var statusCode = initialResponse.Response.StatusCode;
var method = initialResponse.Request.Method;
if (statusCode == HttpStatusCode.OK || statusCode == HttpStatusCode.Accepted ||
(statusCode == HttpStatusCode.Created && method == HttpMethod.Put) ||
(statusCode == HttpStatusCode.Created && (method == HttpMethod.Put || method == new HttpMethod("PATCH"))) ||
Copy link
Copy Markdown
Contributor

@shahabhijeet shahabhijeet Aug 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ScottHolden this change is already put in for the next release for ClientRuntime and is being tracked by #3592
Just curious what scenarios that you have for which you need this fix?
Also all such contributions need test coverage, else the PR will be not be accepted.

Copy link
Copy Markdown
Contributor Author

@ScottHolden ScottHolden Aug 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @shahabhijeet , this change is required for the EventGrid client ( #3600 )

Did you want me to write up some tests for this, or should I close this ahead of Microsoft internally doing the work?

(statusCode == HttpStatusCode.NoContent && (method == HttpMethod.Delete || method == HttpMethod.Post)))
{
return false;
Expand Down