[Event Grid] Generated client with basic scenario tests [DO NOT MERGE]#3600
Closed
ScottHolden wants to merge 1 commit intoAzure:psSdkJson6from
ScottHolden:eventGridDotNet
Closed
[Event Grid] Generated client with basic scenario tests [DO NOT MERGE]#3600ScottHolden wants to merge 1 commit intoAzure:psSdkJson6from ScottHolden:eventGridDotNet
ScottHolden wants to merge 1 commit intoAzure:psSdkJson6from
ScottHolden:eventGridDotNet
Conversation
* Recorded the Eventsubscription tests with PATCH fix. * Re-recorded all tests and added additional TopicType list tests * Added EventHub scoped event subscriptions to tests * Added additional tests annd regenerated client * Added crud and basic scenario tests for EventGrid * Initial commit of generated event grid management client with test framework.
Contributor
|
Can one of the admins verify this patch? |
1 similar comment
Contributor
|
Can one of the admins verify this patch? |
|
@ScottHolden, |
This was referenced Aug 18, 2017
Contributor
|
@ScottHolden please re-open the PR once the PR is ready to be merged and CI passing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, this is a generated EventGrid client :)
Corresponding pull request for the API spec can be found here: Azure/azure-rest-api-specs#1561
Things to note:
**EventSubscription tests will fail until #3592 is resolved **
EventSubscription Storage account test requires access to the preview program, of which the URL isn't live yet, test is skipped
Topic ListEventTypes doesn't seem to work for any providers at the moment, test is skipped until resolved
Resolved: 200 response for delete isn't a part of the swagger spec. Azure/azure-rest-api-specs#1555
Once these 3 outstanding issues have been addressed it should be fine to merge.
Description
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.