Merged
Conversation
* Add test for VMSS Reapply * Record test
…ion (#34878) * Adding $expand query param as part of ListAll VMs in RG and Subscription * Record new test --------- Co-authored-by: Theodore Chang <thchan@microsoft.com>
* br cleanup for net * Update AutomaticOSUpgradePolicy.cs * Update AutomaticOSUpgradePolicy.cs
…rEnabled in SDK (#35466) * Generated SDK and Added test * Install .NET Core 3.1 SDK on Windows to support Track 1 SDK (#35151) * Install .NET Core 3.1 SDK on Windows to support Track 1 * Comment * Install dotnet with tasks instead of template * Install .net core 3.1 for Track 1 .NET SDK * Remove condition * Install .net core 3.1 for test as well --------- Co-authored-by: Wei Hu <live1206@gmail.com>
Co-authored-by: Theodore Chang <thchan@microsoft.com>
…#35233) * adding property * Adding provisionedAfterExtensions in VirtualMachineExtension * reverting the commit * VMSSExtension * added scenario test and record * Reverting back files related to VirtualMachineScaleSetExtension. Changes in VirtualMachineScaleSetVMExtension including adding scenario tests and record. --------- Co-authored-by: Younghyun Kim <younghyunkim@microsoft.com>
grizzlytheodore
requested review from
ArcturusZhang,
ArthurMa1978,
Yao725,
archerzz and
fengzhou-msft
as code owners
Collaborator
|
API change check API changes are not detected in this pull request. |
grizzlytheodore
commented
Apr 19, 2023
...e/Microsoft.Azure.Management.Compute/src/Customizations/VirtualMachineScaleSetVMExtension.cs
Show resolved
Hide resolved
grizzlytheodore
commented
Apr 19, 2023
...mpute/Microsoft.Azure.Management.Compute/src/Generated/IVirtualMachineScaleSetsOperations.cs
Show resolved
Hide resolved
grizzlytheodore
commented
Apr 19, 2023
sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/IVirtualMachinesOperations.cs
Show resolved
Hide resolved
grizzlytheodore
commented
Apr 19, 2023
sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/Models/VirtualMachineRunCommand.cs
Show resolved
Hide resolved
grizzlytheodore
commented
Apr 19, 2023
...te/Microsoft.Azure.Management.Compute/src/Generated/Models/VirtualMachineRunCommandUpdate.cs
Show resolved
Hide resolved
grizzlytheodore
commented
Apr 19, 2023
...pute/Microsoft.Azure.Management.Compute/src/Generated/Models/VirtualMachineScaleSetUpdate.cs
Show resolved
Hide resolved
grizzlytheodore
commented
Apr 19, 2023
...Microsoft.Azure.Management.Compute/src/Generated/Models/VirtualMachineScaleSetVMExtension.cs
Show resolved
Hide resolved
grizzlytheodore
commented
Apr 19, 2023
...ompute/Microsoft.Azure.Management.Compute/src/Generated/VirtualMachineScaleSetsOperations.cs
Show resolved
Hide resolved
grizzlytheodore
commented
Apr 19, 2023
...rosoft.Azure.Management.Compute/src/Generated/VirtualMachineScaleSetsOperationsExtensions.cs
Show resolved
Hide resolved
grizzlytheodore
commented
Apr 19, 2023
sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/VirtualMachinesOperations.cs
Show resolved
Hide resolved
ArcturusZhang
approved these changes
Apr 20, 2023
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.