Install .NET Core 3.1 SDK on Windows to support Track 1 SDK by live1206 · Pull Request #35151 · Azure/azure-sdk-for-net

live1206 · 2023-03-27T03:39:05Z

.NET Core 3.1 SDK does not exist on Windows hosted machine anymore, we still need it for Track 1 SDK
https://github.com/Azure/azure-sdk-for-net/pull/35148/checks?check_run_id=12290486264

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

live1206 · 2023-03-27T12:00:26Z

@weshaggard Could you help to review this? Thanks!

jsquire · 2023-03-27T12:53:06Z

@live1206: Please help me understand why we need a runtime that has reached end-of-life and is no longer supported. What libraries are failing and what target are they using?

//fyi: @heaths

jsquire

Blocking merge until the scenario is understood.

weshaggard · 2023-03-27T19:41:00Z

@live1206 I thought we were rolling forward to the latest .NET when running the code generation so why would we still need this? Is there something else that needs it?

Looking at your link it appears as though there are still some test projects targeting .NET Core 3.1. We should instead update those test projects to .NET 7.0 as .NET 3.1 is out support.

benbp · 2023-03-27T23:27:06Z

If this is indeed not necessary, I have a PR to remove the step entirely as we don't need to be wasting time on windows jobs installing it: #35174

live1206 · 2023-03-28T09:23:05Z

@live1206 I thought we were rolling forward to the latest .NET when running the code generation so why would we still need this? Is there something else that needs it?

Looking at your link it appears as though there are still some test projects targeting .NET Core 3.1. We should instead update those test projects to .NET 7.0 as .NET 3.1 is out support.

Tried with a draft PR #35178, it takes more effort than expected.
Basically a follow-up of #32814

jsquire · 2023-03-28T14:18:07Z

Tried with a draft PR #35178, it takes more effort than expected. Basically a follow-up of #32814

There's a difference between building with the .NET 7 SDK and changing the target frameworks for libraries. We need to do the former, we do not want to do the latter.

@live1206 - would you please help us understand what problem you're trying to solve? What behavior are you seeing that requires changes?

live1206 · 2023-03-29T05:24:14Z

https://github.com/Azure/azure-sdk-for-net/pull/35148/checks?check_run_id=12290486264

@jsquire As I mentioned in the description, the CI is failing for Track 1 .NET SDK PR: https://github.com/Azure/azure-sdk-for-net/pull/35148/checks?check_run_id=12290486264, it is blocking Track 1 .NET SDK release. The reason the Track 1 CI failure is the Track 1 tests are requiring .NET core 3.1 during the run.

jsquire · 2023-03-29T13:27:51Z

@jsquire As I mentioned in the description, the CI is failing for Track 1 .NET SDK

What should change here is the SDK in use; these should be compiled using the .NET 7 SDK. We do not want to install/use the .NET Core 3.1 SDK, as it has reached end-of-life.

live1206 · 2023-03-30T00:13:22Z

@jsquire As I mentioned in the description, the CI is failing for Track 1 .NET SDK

What should change here is the SDK in use; these should be compiled using the .NET 7 SDK. We do not want to install/use the .NET Core 3.1 SDK, as it has reached end-of-life.

As I explained in #35178 (comment), it's not an easy fix to upgrade the target .NET to latest.

eng/pipelines/templates/steps/install-dotnet.yml

Dismissing block as a path forward has been agreed upon to unblock the release and address the underlying dependency issue in the longer term.

eng/pipelines/templates/jobs/ci.mgmt.yml

weshaggard · 2023-04-04T16:33:35Z

/azp run net - mgmt

azure-pipelines · 2023-04-04T16:33:42Z

No pipelines are associated with this pull request.

weshaggard · 2023-04-04T16:34:03Z

I'd like to make sure we get a test run of the mgmt pipeline as well to ensure this change works as expected.

weshaggard · 2023-04-04T16:34:43Z

/azp run net - mgmt - ci

azure-pipelines · 2023-04-04T16:34:56Z

Azure Pipelines failed to run 1 pipeline(s).

live1206 · 2023-04-06T03:43:18Z

/azp run net - mgmt - ci

azure-pipelines · 2023-04-06T03:43:29Z

Azure Pipelines successfully started running 1 pipeline(s).

) * Install .NET Core 3.1 SDK on Windows to support Track 1 * Comment * Install dotnet with tasks instead of template * Install .net core 3.1 for Track 1 .NET SDK * Remove condition * Install .net core 3.1 for test as well

…rEnabled in SDK (#35466) * Generated SDK and Added test * Install .NET Core 3.1 SDK on Windows to support Track 1 SDK (#35151) * Install .NET Core 3.1 SDK on Windows to support Track 1 * Comment * Install dotnet with tasks instead of template * Install .net core 3.1 for Track 1 .NET SDK * Remove condition * Install .net core 3.1 for test as well --------- Co-authored-by: Wei Hu <live1206@gmail.com>

* generated with 2023-03-01 tag * update version * new recordings for all tests * sanitize key * last test recording * Add test for VMSS Reapply (#34738) * Add test for VMSS Reapply * Record test * Adding $expand query param as part of ListAll VMs in RG and Subscription (#34878) * Adding $expand query param as part of ListAll VMs in RG and Subscription * Record new test --------- Co-authored-by: Theodore Chang <thchan@microsoft.com> * Add VM property (#34842) (#34938) Co-authored-by: payalguptapg <126145083+payalguptapg@users.noreply.github.com> Co-authored-by: Theodore Chang <theodore.l.chang@gmail.com> * Remove <br> syntax from most CRP swagger descriptions (#35016) * br cleanup for net * Update AutomaticOSUpgradePolicy.cs * Update AutomaticOSUpgradePolicy.cs * Add Compute SecurityPosture SDK for 2023-03-01 (#35345) * Adding Restore Point Encryption, HyperVGeneration and WriteAcceleratorEnabled in SDK (#35466) * Generated SDK and Added test * Install .NET Core 3.1 SDK on Windows to support Track 1 SDK (#35151) * Install .NET Core 3.1 SDK on Windows to support Track 1 * Comment * Install dotnet with tasks instead of template * Install .net core 3.1 for Track 1 .NET SDK * Remove condition * Install .net core 3.1 for test as well --------- Co-authored-by: Wei Hu <live1206@gmail.com> * Add sdk support for vmss deallocate hibernate optional parameter (#35335) * dedicated host Resize (#35197) Co-authored-by: Theodore Chang <thchan@microsoft.com> * Adding missing property for VirtualMachineExtension and VMSSExtension (#35233) * adding property * Adding provisionedAfterExtensions in VirtualMachineExtension * reverting the commit * VMSSExtension * added scenario test and record * Reverting back files related to VirtualMachineScaleSetExtension. Changes in VirtualMachineScaleSetVMExtension including adding scenario tests and record. --------- Co-authored-by: Younghyun Kim <younghyunkim@microsoft.com> * regenerated, metatags * customizations * sanitized SAS recordings for compliance CI * finish customization. resolve build failure --------- Co-authored-by: Theodore Chang <theodore.l.chang@gmail.com> Co-authored-by: Anshul Verma <88476874+AnshulVermaa@users.noreply.github.com> Co-authored-by: Kartik Gupta <31189137+Kartik-715@users.noreply.github.com> Co-authored-by: payalguptapg <126145083+payalguptapg@users.noreply.github.com> Co-authored-by: Adam Sandor <adsandor@microsoft.com> Co-authored-by: mabhard <52765900+mabhard@users.noreply.github.com> Co-authored-by: Linu George <127192938+linugeorgeofficial@users.noreply.github.com> Co-authored-by: Wei Hu <live1206@gmail.com> Co-authored-by: vatsan28 <vatsan9228@gmail.com> Co-authored-by: cakarata <47228825+cakarata@users.noreply.github.com> Co-authored-by: younghyun5756 <102988755+younghyun5756@users.noreply.github.com> Co-authored-by: Younghyun Kim <younghyunkim@microsoft.com>

Install .NET Core 3.1 SDK on Windows to support Track 1

3b0a037

live1206 requested review from benbp, hallipr and weshaggard as code owners March 27, 2023 03:39

live1206 changed the title ~~Install .NET Core 3.1 SDK on Windows to support Track 1~~ Install .NET Core 3.1 SDK on Windows to support Track 1 SDK Mar 27, 2023

Comment

d80f13a

jsquire previously requested changes Mar 27, 2023

View reviewed changes

weshaggard mentioned this pull request Mar 28, 2023

Remove install step for NET 3.1 #35174

Merged

live1206 mentioned this pull request Mar 29, 2023

Upgrade .NET core 3.1 to .NET 6 #35178

Closed

mikeharder mentioned this pull request Mar 30, 2023

Upgrade Python to 3.9 #35229

Merged

weshaggard reviewed Apr 4, 2023

View reviewed changes

eng/pipelines/templates/steps/install-dotnet.yml Outdated Show resolved Hide resolved

live1206 added 2 commits April 4, 2023 14:40

Install dotnet with tasks instead of template

2d38be1

Install .net core 3.1 for Track 1 .NET SDK

4ba5538

Merge remote-tracking branch 'origin/main' into fix-track1-ci

14f35e5

weshaggard reviewed Apr 4, 2023

View reviewed changes

eng/pipelines/templates/jobs/ci.mgmt.yml Outdated Show resolved Hide resolved

weshaggard approved these changes Apr 4, 2023

View reviewed changes

weshaggard reviewed Apr 4, 2023

View reviewed changes

eng/pipelines/templates/jobs/ci.mgmt.yml Show resolved Hide resolved

Remove condition

64220b8

Install .net core 3.1 for test as well

bbe5760

live1206 force-pushed the fix-track1-ci branch from 507f346 to bbe5760 Compare April 6, 2023 05:53

Merge remote-tracking branch 'origin/main' into fix-track1-ci

6ca5d15

weshaggard approved these changes Apr 6, 2023

View reviewed changes

live1206 merged commit d1b08d9 into Azure:main Apr 7, 2023

live1206 deleted the fix-track1-ci branch April 7, 2023 00:47

Conversation

live1206 commented Mar 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Contributing to the Azure SDK

Uh oh!

live1206 commented Mar 27, 2023

Uh oh!

jsquire commented Mar 27, 2023

Uh oh!

jsquire left a comment

Choose a reason for hiding this comment

Uh oh!

weshaggard commented Mar 27, 2023

Uh oh!

benbp commented Mar 27, 2023

Uh oh!

live1206 commented Mar 28, 2023

Uh oh!

jsquire commented Mar 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

live1206 commented Mar 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jsquire commented Mar 29, 2023

Uh oh!

live1206 commented Mar 30, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

weshaggard commented Apr 4, 2023

Uh oh!

azure-pipelines bot commented Apr 4, 2023

Uh oh!

weshaggard commented Apr 4, 2023

Uh oh!

weshaggard commented Apr 4, 2023

Uh oh!

azure-pipelines bot commented Apr 4, 2023

Uh oh!

live1206 commented Apr 6, 2023

Uh oh!

azure-pipelines bot commented Apr 6, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

live1206 commented Mar 27, 2023 •

edited

Loading

jsquire commented Mar 28, 2023 •

edited

Loading

live1206 commented Mar 29, 2023 •

edited

Loading