Fix parameter name and structure for radius server setting for VpnGat…#3524
Fix parameter name and structure for radius server setting for VpnGat…#3524ritwikbasu wants to merge 1 commit intoAzure:psSdkJson6from ritwikbasu:psSdkJson6
Conversation
…eways. Fix parameter name and structure for radius server setting for VpnGateways.
shahabhijeet
left a comment
shahabhijeet
left a comment
There was a problem hiding this comment.
@ritwikbasu if this is a breaking change.
Bump up the major version.
Also where are the tests for this change?
| /// 'Deleting', and 'Failed'.</param> | ||
| /// <param name="etag">Gets a unique read-only string that changes | ||
| /// whenever the resource is updated.</param> | ||
| public VirtualNetworkGateway(string id = default(string), string name = default(string), string type = default(string), string location = default(string), IDictionary<string, string> tags = default(IDictionary<string, string>), IList<VirtualNetworkGatewayIPConfiguration> ipConfigurations = default(IList<VirtualNetworkGatewayIPConfiguration>), string gatewayType = default(string), string vpnType = default(string), bool? enableBgp = default(bool?), bool? activeActive = default(bool?), SubResource gatewayDefaultSite = default(SubResource), VirtualNetworkGatewaySku sku = default(VirtualNetworkGatewaySku), VpnClientConfiguration vpnClientConfiguration = default(VpnClientConfiguration), BgpSettings bgpSettings = default(BgpSettings), string radiusServer = default(string), string radiusSecret = default(string), string resourceGuid = default(string), string provisioningState = default(string), string etag = default(string)) |
There was a problem hiding this comment.
@ritwikbasu so anyone who use to provide radiusServer info will be broken during constructing VirtualNetworkGateway?
There was a problem hiding this comment.
This feature is not exposed to customers. It has been deployed in NRP but is protected by a feature flag. This change ensures that the contract matches NRP and the documentation that will go out to the customer once the feature is released publicly.
The correct behavior is that radius settings should go as part of VpnClientConfiguration object when the feature is released. That is also the behavior in ARM/NRP now. This is a bugfix on the previous iteration which exposed radius address.
There was a problem hiding this comment.
This is not a breaking change - this is a bugfix.
The tests are compiled as part of the powershell release. This specific change requires pre-setup that is already available in powershell.
3 participants
…eways.
Fix parameter name and structure for radius server setting for
VpnGateways.
Description
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.The Rest-API-Spec PR for this change is here:
Azure/azure-rest-api-specs#1484